31783[BUGFIX] colPos_list sets access to edit areas
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Jo Hasenau +1
- Wouter Wolters +1
- Marcin Sągol +1
-
Verified V +2
- Jigal van Hemert +2
Issues 1
Files 2
Review log 26
Show 1 earlier messages
-
Jigal van Hemert uploaded patch set 1 07/24/14, 23:19
-
Jo Hasenau commented on patch set 1 CR -1 V +1 07/25/14, 09:38
As long as there is no TSconfig stuff, the activeColPosList will be matching the colPosList anyway, so IMHO there should be a check for TSconfig in the first place to avoid the array magic when it is not necessary. -
Jo Hasenau commented on patch set 1 V -1 07/25/14, 09:45
Have to revoke my verified as well, since the logic is wrong as well. A column is "unassigned" when there is no colPos set for it (this would be true for placeholder columns) The correct setting for columns being in colPosList but not in activeColPosList is "no access", since they are assigned but not accessible for the current combination of page and user -
Jo Hasenau uploaded patch set 2 07/25/14, 10:00
-
Jo Hasenau uploaded patch set 3 07/25/14, 10:05
-
Jo Hasenau commented on patch set 3 07/25/14, 10:05
Forgot to insert the check for the class "restricted" after removing it for "unassigned" -
Jigal van Hemert commented on patch set 3 V -1 CR -1 07/25/14, 10:08
Can't do an array_intersect() on strings :-)PageLayoutController.php:548These are strings with comma separated lists of colPos numbers and can't be used with array_intersect() -
Jo Hasenau commented on patch set 3 07/25/14, 10:20
Sorry - will come up with a new one -
Jo Hasenau uploaded patch set 4 07/25/14, 10:21
-
Jo Hasenau uploaded patch set 5 07/25/14, 10:22
-
Jo Hasenau commented on patch set 5 07/25/14, 10:24
All these explodes of imploded explodes are sometimes confusing but I guess now we got the lowest possible number ;-) -
Jigal van Hemert commented on patch set 5 CR +1 V +1 07/25/14, 10:32
All explosions and implosions are now properly mixed. With the rewrite I think I can vote a +1 here. -
Wouter Wolters commented on patch set 5 CR -1 07/25/14, 13:38
Will push an updatePageLayoutController.php:113Include Module shared TSconfig inside the phpDoc, No ; after the type arrayPageLayoutController.php:220no ; after type stringPageLayoutController.php:542space after if -
Wouter Wolters commented on patch set 5 07/25/14, 13:42
PageLayoutView.php:631space between ){ -
Wouter Wolters uploaded patch set 6 07/25/14, 13:42
-
Wouter Wolters voted on patch set 6 CR +1 07/25/14, 13:44
-
Marcin Sągol voted on patch set 6 CR +1 07/26/14, 07:21
-
Jo Hasenau commented on patch set 6 V +1 CR +1 07/26/14, 09:12
+1 counts for the latest changes, since I am not supposed to vote for my own rewrite. -
Jo Hasenau voted on patch set 6 V 0 07/26/14, 09:13
-
Stephan Großberndt commented on patch set 6 09/05/14, 18:37
Are more reviews/ verified needed here? -
Markus Klein commented on patch set 6 09/06/14, 17:01
This needs 2 more verified! -
Jigal van Hemert commented on patch set 6 CR +2 V +2 09/07/14, 15:02
No functional changes since my last review. -
Jigal van Hemert merged patch set 6 09/07/14, 15:02
-
Jigal van Hemert commented on patch set 7 09/07/14, 15:03
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit c6f31cbecae8fa51ed80b91c43fe3c449cf9b527 -
Helmut Hummel commented on patch set 7 09/10/14, 08:17
This breaks backend layouts! all content columns are marked as not editable. Shall we revert? -
Helmut Hummel commented on patch set 7 09/10/14, 08:28
PageLayoutController.php:223does this need to be public?PageLayoutController.php:544In this case $this->activeColPosList is an arrayPageLayoutView.php:623if activeCols is an array, then all these checks break