Review main Merged

31790[BUGFIX] Labels in extension manager not loaded

Susi Moog CR +2 V +2 Expert +64 −1543 updated 07/25/14, 13:26

Commit message

The extensionmanager tries to load language labels from the
old extension manager.

Add the needed labels to the extension manager language file and
delete the old file. Simultaneously refactor the language handling
a bit.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Christian Kuhn +1

Issues 1

Files 6

Review log 22

  1. Susi Moog uploaded patch set 1 07/25/14, 08:57

  2. Susi Moog updated the commit message in patch set 2 07/25/14, 09:06

  3. Susi Moog uploaded patch set 3 07/25/14, 09:31

  4. Fabien Udriot voted on patch set 3 CR +1 07/25/14, 10:24

  5. Wouter Wolters commented on patch set 3 CR -1 07/25/14, 11:07

    FileHandlingUtility.php:49

    Where is objectManager defined as property?

    FileHandlingUtilityTest.php:35

    double slashes for the class name

    FileHandlingUtilityTest.php:209

    double slashed for the class name
  6. Wouter Wolters uploaded patch set 4 07/25/14, 11:11

  7. Markus Klein commented on patch set 3 07/25/14, 11:11

    locallang.xlf:506

    Please adopt the naming of the labels for the new labels
  8. Markus Klein commented on patch set 4 07/25/14, 11:12

    locallang.xlf:506

    See comment in set 3
  9. Wouter Wolters commented on patch set 4 V -1 07/25/14, 11:25

    Seems the labels are not translated.. for example the extension status report is empty. Investigating..
  10. Wouter Wolters commented on patch set 4 V 0 07/25/14, 11:39

    Update in a minute

    ExtensionStatus.php:65

    LLL: should not be here

    FileHandlingUtility.php:495

    LLL: should not be here
  11. Wouter Wolters uploaded patch set 5 07/25/14, 11:40

  12. Wouter Wolters uploaded patch set 6 07/25/14, 11:59

  13. Wouter Wolters voted on patch set 6 V +1 CR +1 07/25/14, 11:59

  14. Christian Kuhn commented on patch set 6 07/25/14, 12:05

    FileHandlingUtility.php:41

    @inject here instead of makeInstance in __construct()?

    FileHandlingUtility.php:55

    move this call to an initialize() method?
  15. Christian Kuhn commented on patch set 6 CR -1 07/25/14, 12:06

    -1 for now.
  16. Susi Moog uploaded patch set 7 07/25/14, 12:32

  17. Susi Moog uploaded patch set 8 07/25/14, 12:33

  18. Wouter Wolters voted on patch set 8 V +1 CR +1 07/25/14, 12:39

  19. Markus Klein voted on patch set 8 CR +1 07/25/14, 13:01

  20. Christian Kuhn voted on patch set 8 CR +1 V +1 07/25/14, 13:26

  21. Anja Leichsenring voted on patch set 8 CR +2 V +2 07/25/14, 13:26

  22. Anja Leichsenring merged patch set 8 07/25/14, 13:26