31790[BUGFIX] Labels in extension manager not loaded
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Wouter Wolters +1
- Christian Kuhn +1
Issues 1
Files 6
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php1+27 −26
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php4+22 −11
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf2+10 −1
- typo3/sysext/extensionmanager/Tests/Unit/Controller/UploadExtensionFileControllerTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php2+4 −2
- typo3/sysext/lang/locallang_mod_tools_em.xlfdeleted+0 −1502
Review log 22
-
Susi Moog uploaded patch set 1 07/25/14, 08:57
-
Susi Moog updated the commit message in patch set 2 07/25/14, 09:06
-
Susi Moog uploaded patch set 3 07/25/14, 09:31
-
Fabien Udriot voted on patch set 3 CR +1 07/25/14, 10:24
-
Wouter Wolters commented on patch set 3 CR -1 07/25/14, 11:07
FileHandlingUtilityTest.php:35double slashes for the class nameFileHandlingUtilityTest.php:209double slashed for the class name -
Wouter Wolters uploaded patch set 4 07/25/14, 11:11
-
Markus Klein commented on patch set 3 07/25/14, 11:11
locallang.xlf:506Please adopt the naming of the labels for the new labels -
Markus Klein commented on patch set 4 07/25/14, 11:12
locallang.xlf:506See comment in set 3 -
Wouter Wolters commented on patch set 4 V -1 07/25/14, 11:25
Seems the labels are not translated.. for example the extension status report is empty. Investigating.. -
Wouter Wolters commented on patch set 4 V 0 07/25/14, 11:39
Update in a minuteExtensionStatus.php:65LLL: should not be hereFileHandlingUtility.php:495LLL: should not be here -
Wouter Wolters uploaded patch set 5 07/25/14, 11:40
-
Wouter Wolters uploaded patch set 6 07/25/14, 11:59
-
Wouter Wolters voted on patch set 6 V +1 CR +1 07/25/14, 11:59
-
Christian Kuhn commented on patch set 6 07/25/14, 12:05
FileHandlingUtility.php:41@inject here instead of makeInstance in __construct()?FileHandlingUtility.php:55move this call to an initialize() method? -
Christian Kuhn commented on patch set 6 CR -1 07/25/14, 12:06
-1 for now. -
Susi Moog uploaded patch set 7 07/25/14, 12:32
-
Susi Moog uploaded patch set 8 07/25/14, 12:33
-
Wouter Wolters voted on patch set 8 V +1 CR +1 07/25/14, 12:39
-
Markus Klein voted on patch set 8 CR +1 07/25/14, 13:01
-
Christian Kuhn voted on patch set 8 CR +1 V +1 07/25/14, 13:26
-
Anja Leichsenring voted on patch set 8 CR +2 V +2 07/25/14, 13:26
-
Anja Leichsenring merged patch set 8 07/25/14, 13:26
FileHandlingUtility.php:49