Review main Merged

31816[BUGFIX] Install Tool image tests: black background after scaling

Susi Moog CR +2 V +2 Easy +1 −1 updated 07/25/14, 17:55

Commit message

Transparent turns black unless you specify a different color
because transparent = unset color = 0 = black. We should fix this
by adding the "-opaque white -background white -flatten"
parameters for the convert action done
by the install tool.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Files 1

Review log 12

  1. Susi Moog uploaded patch set 1 07/25/14, 15:07

  2. Christian Kuhn updated the commit message in patch set 2 07/25/14, 15:23

  3. Christian Kuhn commented on patch set 2 V -1 07/25/14, 15:42

    The last test of "scaling images" now works with ImageMagick! Yeah :) But the GraphicsMagick result is still broken.
  4. Susi Moog uploaded patch set 3 07/25/14, 16:12

  5. Christian Kuhn commented on patch set 3 07/25/14, 17:35

    works both in im and gm! :)
  6. Christian Kuhn voted on patch set 3 CR +1 V +1 07/25/14, 17:35

  7. Wouter Wolters commented on patch set 3 07/25/14, 17:38

    will try it out
    opaque none is changed now. this needs to be adjusted.
  8. Wouter Wolters updated the commit message in patch set 4 07/25/14, 17:50

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 07/25/14, 17:55

  10. Wouter Wolters voted on patch set 4 V +2 CR +2 07/25/14, 17:55

  11. Wouter Wolters merged patch set 4 07/25/14, 17:55

  12. Wouter Wolters commented on patch set 5 07/25/14, 17:55

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 6c786ffb736f57516877eab0606e3b37f5875269