Review main Merged

31835[CLEANUP] Let expected exceptions test for code, not text

Anja Leichsenring CR +2 V +2 Easy +6 −6 updated 07/25/14, 19:53

Commit message

When an exception is expected in DependencyUtilityTest, the correct
exception is tested by text. The change of wording of some of those
exceptions caused the related test to fail.

Testing for the exception code instead of the text opens the
possibility to adapt display messages, while the exception code stays
unchanged and stabilizes tests against false positives.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 1

Review log 6

  1. Anja Leichsenring uploaded patch set 1 07/25/14, 19:39

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 07/25/14, 19:51

  3. Susi Moog voted on patch set 1 CR +1 V +1 07/25/14, 19:53

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 07/25/14, 19:53

  5. Christian Kuhn merged patch set 1 07/25/14, 19:53

  6. Christian Kuhn commented on patch set 2 07/25/14, 19:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 4b5b892a2fcac228ed1fb378c505c4907d86ebf1