Review main Merged

3186[CLEANUP] make TCEmain::getInlineFieldType() more understandable

Andreas Wolf CR +2 V +2 Easy +13 −15 updated 06/03/13, 20:49

Commit message

With 933254e2e69df05b41ae1f3b026a8f4c6f8fc09d, the method was made more
complicated without an obvious need for that. This patch reverts these
change, plus moving the guard clause to the beginning with an early
return in it, thus making the structure even more obvious.

This change has been integrated into the original patch for 4.5.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Files 1

Review log 4

  1. Andreas Wolf commented on patch set 1 V 0 07/09/11, 13:28

    by team member; Looks good to me, approved Pushing after a positive review from another Core Team member and a check for syntax errors with php -l.
  2. Steffen Ritter commented on patch set 1 07/09/11, 13:28

    Looks good to me, approved just some cleanup - go ahead
  3. Mr. Jenkins commented on patch set 1 07/09/11, 13:28

  4. Andreas Wolf merged patch set 1 07/09/11, 13:28