Review main Merged

31873[BUGFIX] Refine the error message of checkMaximumFileUploadSize

Markus Klein CR +2 V +2 Easy +4 −4 updated 07/28/14, 13:19

Commit message

The Install Tool check the PHP configuration for the maximum file
upload size within the checkMaximumFileUploadSize() method.
This method issues an error message in case the values do not fit.
The error message outputs the values in MB which might give a
wrong indication to the user, as the values seem to be equal
although the check complains they are not.

Provide better output by giving those numbers in KB rather than MB,
which will show diverging numbers correctly then.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Hünniger +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Hünniger +1

Issues 1

Files 1

Review log 9

  1. Markus Klein uploaded patch set 1 07/27/14, 20:44

  2. Markus Klein commented on patch set 1 CR -2 07/27/14, 20:48

    Maybe not an issue.
  3. Markus Klein uploaded patch set 2 07/27/14, 21:07

  4. Markus Klein voted on patch set 1 CR 0 07/27/14, 21:07

  5. Markus Klein voted on patch set 2 CR 0 07/27/14, 21:07

  6. Christian Hünniger voted on patch set 2 CR +1 V +1 07/27/14, 21:15

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 07/28/14, 13:19

  8. Wouter Wolters merged patch set 2 07/28/14, 13:19

  9. Wouter Wolters commented on patch set 3 07/28/14, 13:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit aa218a9e36737da09a8e53964e6687c5a004bf1a