Review main Merged

31874[TASK] Add unit tests for forceAbsoluteUrl()

Markus Klein CR +2 V +2 Normal +87 −5 updated 09/09/14, 11:10

Commit message

ContentObjectRenderer::forceAbsoluteUrl() is not covered by unit tests
at all.
Add unit tests and improve mocking in other existing tests.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 10

  1. Markus Klein uploaded patch set 1 07/27/14, 23:09

  2. Markus Klein uploaded patch set 2 07/28/14, 17:40

  3. Anja Leichsenring voted on patch set 2 CR +1 V +1 09/08/14, 13:48

  4. Christian Kuhn commented on patch set 2 09/08/14, 14:13

    ContentObjectRendererTest.php:1697

    $this->once() maybe?
  5. Christian Kuhn uploaded patch set 3 09/08/14, 14:16

  6. Christian Kuhn voted on patch set 3 CR +1 V +1 09/08/14, 14:16

  7. Christian Kuhn commented on patch set 3 09/08/14, 14:17

    just changed a this->any() to a this->once() where it seemed useful.
  8. Anja Leichsenring voted on patch set 3 CR +2 V +2 09/08/14, 14:20

  9. Anja Leichsenring merged patch set 3 09/08/14, 14:20

  10. Anja Leichsenring commented on patch set 4 09/09/14, 11:10

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 87684d2514aabaedb93e4bfda12856774bd27db5