Review main Merged

31898[FEATURE] Allow appending of element browser mounts

Alexander Stehlik CR +2 V +2 Normal +86 −24 updated 01/23/15, 08:33

Commit message

A new User TSconfig option is introduced that allows the alternative
element browser page tree mounts to be appended instead of beeing
replaced:

options.pageTree.altElementBrowserMountPoints.append

Additionally the handling of temporary mount points within the RTE
and the wizard element browser is unified. If a temporary mount
point is active the altElementBrowserMountPoints will be ignored.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
    • Alexander Stehlik +1
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Alexander Stehlik +1
    • Anja Leichsenring +1

Issues 1

Files 5

Review log 40

Show 15 earlier messages
  1. Alexander Stehlik uploaded patch set 1 07/29/14, 13:27

  2. Frank Nägler commented on patch set 1 09/17/14, 21:46

    I think we need a documentation file in sysext/core/Documentation for this patch. Also it was not possible to test this feature, can you describe a little bit more how to test this?

    BackendUtility.php:4191

    I would prefer to use the Class without FQN, use "use" statement to import
  3. Alexander Stehlik uploaded patch set 2 11/16/14, 14:25

  4. Alexander Stehlik uploaded patch set 3 11/16/14, 14:35

  5. Alexander Stehlik commented on patch set 3 11/16/14, 14:36

    Added documentation and introduced "use" statements as suggested by Frank.
  6. Alexander Stehlik uploaded patch set 4 11/16/14, 14:55

  7. Alexander Stehlik commented on patch set 4 11/16/14, 14:56

    Added missing spaces in ChangeLog rst file.
  8. Markus Klein commented on patch set 4 11/19/14, 16:25

    BackendUtility.php:4294

    please use $beUser here too
  9. Alexander Stehlik uploaded patch set 5 11/19/14, 16:29

  10. Alexander Stehlik commented on patch set 4 11/19/14, 16:29

    Thank you, Markus :)

    BackendUtility.php:4294 Reply

    Done
  11. Markus Klein uploaded patch set 6 11/19/14, 17:15

  12. Markus Klein commented on patch set 6 CR +1 11/19/14, 17:16

    ElementBrowserController.php:100

    The whole thing is a bit strange. We read pageTree_temporaryMountPoint and cast it to int, but this could actually be a list of uids.
  13. Frans Saris commented on patch set 6 CR -1 11/19/14, 17:31

    Feature-50780-AppendElementBrowserMountPoints.rst:8

    A new ....

    ElementBrowserController.php:99

    If I read the code correct it should default to a empty string and not to 0
  14. Alexander Stehlik uploaded patch set 7 11/19/14, 17:51

  15. Alexander Stehlik commented on patch set 6 11/19/14, 17:53

    ElementBrowserController.php:100 Reply

    Sorry guys, Gerrits seems to have messed up the diff view. The code in my local diff was looking totally different. Please have a look at the new version, it seems to be fixed now.
  1. Markus Klein commented on patch set 7 CR -1 11/19/14, 18:07

    you didn't pick my latest changeset and therefore reverted all my changes

    BackendUtility.php:4283

    separated

    BackendUtility.php:4287

    MountPoints
  2. Alexander Stehlik commented on patch set 7 11/19/14, 18:13

    Sorry, Markus, I totally missed that. That explains the code changes though ;) I'll fix that.
  3. Alexander Stehlik uploaded patch set 8 11/19/14, 18:19

  4. Alexander Stehlik commented on patch set 8 11/19/14, 18:22

    ElementBrowserController.php:96

    For what did we need this in the first place? ;)
  5. Markus Klein voted on patch set 8 CR +1 V +1 11/19/14, 18:40

  6. Frans Saris voted on patch set 8 CR +1 11/19/14, 18:45

  7. Benni Mack uploaded patch set 9 01/03/15, 19:19

  8. Anja Leichsenring voted on patch set 9 CR +1 V +1 01/03/15, 19:39

  9. Benni Mack commented on patch set 9 01/03/15, 20:06

    FYI: I think the method belongs to BackendUser not to BackendUtility, that's why I made the change. Furthermore I wanted it to work with arrays.
  10. Markus Klein commented on patch set 9 01/03/15, 23:52

    Feature-50780-AppendElementBrowserMountPoints.rst:30

    reading this again, I'd suggest to call this option .append to make it clear that this is a suboption. options.pageTree.altElementBrowserMountPoints.append = 1
  11. Benni Mack commented on patch set 9 01/04/15, 10:00

    good idea, could you update the patch accordingly?
  12. Markus Klein uploaded patch set 10 01/04/15, 12:26

  13. Markus Klein voted on patch set 10 CR +1 01/04/15, 12:28

  14. Benni Mack uploaded patch set 11 01/04/15, 13:48

  15. Markus Klein voted on patch set 11 CR +1 01/04/15, 20:46

  16. Alexander Stehlik commented on patch set 11 V -1 01/07/15, 12:20

    There currently seems to be a discrepancy between the behavior in the RTE element browser and the wizard element browser when temporary mount points are used. In the RTE element browser ONLY the temporary mount point is displayed if it is active. In the wizard element browser the temporary mount point is displayed AND the appended element browser mount point. I think if a temporary mount point is set the additional configured mount points should be ignored. I try to unify this.
  17. Alexander Stehlik commented on patch set 11 01/07/15, 14:24

    Testing the abbreviation RTE stuff is kind of a nightmare ;) See: https://forge.typo3.org/issues/64165 and: https://forge.typo3.org/issues/64169
  18. Alexander Stehlik uploaded patch set 12 01/07/15, 15:10

  19. Alexander Stehlik commented on patch set 12 CR +1 V +1 01/07/15, 15:13

    ElementBrowserController.php:112

    Moved this in the else block so that the wizard element browser behaves like the RTE element browser (if temporary mount point is present, altElementBrowserMountPoints are ignored).

    Abbreviation.php:191

    Added initialization of the variable to prevent IDE warnings.
  20. Alexander Stehlik commented on patch set 12 01/07/15, 15:14

    For testing the RTE abbreviation stuff you need to apply these patches: https://review.typo3.org/#/c/35863/ https://review.typo3.org/#/c/35864/
  21. Anja Leichsenring voted on patch set 12 CR +1 V +1 01/18/15, 10:53

  22. Markus Klein commented on patch set 12 CR +1 01/19/15, 00:31

    ElementBrowserController.php:105

    whatever this part of the commit message wants to tell us
  23. Benni Mack commented on patch set 12 CR +2 V +2 01/22/15, 19:15

    enough reviews and verified. will merge now
  24. Benni Mack merged patch set 12 01/22/15, 19:15

  25. Alexander Stehlik commented on patch set 13 01/23/15, 08:33

    Thank you all :)