31920[BUGFIX] Property of alternative model implementation not found
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Tymoteusz Motylewski +1
-
Verified V +2
- Markus Klein +2
- Tymoteusz Motylewski +1
Issues 1
Files 3
Review log 21
-
Oliver Hader uploaded patch set 1 07/31/14, 13:19
-
Oliver Hader updated the commit message in patch set 2 07/31/14, 13:30
-
Tymoteusz Motylewski commented on patch set 2 08/24/14, 15:18
would be nice if you can upload some test extension to speed up the testing -
Markus Klein updated the commit message in patch set 3 08/24/14, 19:45
-
Markus Klein voted on patch set 3 CR +1 08/24/14, 19:46
-
Mathias Brodala voted on patch set 3 CR +1 08/25/14, 13:38
-
Tymoteusz Motylewski commented on patch set 3 09/12/14, 21:17
How to reproduce/test this issue? I would like to review it, but without the real case I can only do code -review. -
Oliver Hader commented on patch set 3 09/20/14, 13:59
@Tymek: e.g. extend a FrontendUser domain model with your own implementation. Register that one in config.tx_extbase.objects as alternative. Then a simple controller action like show(MyFrontendUser $frontendUser) is enough to trigger this.. -
Oliver Hader commented on patch set 3 09/20/14, 14:00
... argh wrong... the action method must contain the original class name as type hint, thus "FrontendUser" instead of "MyFrontendUser": show(FrontendUser $frontendUser) {} -
Tymoteusz Motylewski commented on patch set 3 09/21/14, 11:18
This is what I have tried (not with fe_users, but different model), however I've got all the properties when using f.debug in the view on the passed model. I will try again, when I have a moment. -
Oliver Hader commented on patch set 3 09/21/14, 13:40
Ah, of course the extended model needs to define a new property that is not used in the base class. And this new property needs to be submitted with the request -
Helmut Hummel updated the commit message in patch set 4 09/22/14, 14:59
-
Helmut Hummel commented on patch set 4 CR -1 09/22/14, 15:01
https://review.typo3.org/#/c/22135/ Should one be abandoned in favor of the other? -
Tymoteusz Motylewski commented on patch set 4 CR +1 V +1 09/23/14, 12:29
tested with the use case from https://review.typo3.org/#/c/22135/3 This change is less invasive than the other, so we should merge this one. -
Tymoteusz Motylewski commented on patch set 4 10/02/14, 14:27
the other patch was abandoned, so we can proceed with this one. @Helmut, can you remove the -1 if it was only related to having 2 patches for the same problem? -
Tymoteusz Motylewski updated the commit message in patch set 5 10/15/14, 19:32
-
Tymoteusz Motylewski commented on patch set 5 CR +1 V +1 10/15/14, 19:33
reapplying the votes after commit message change -
Markus Klein voted on patch set 5 CR +2 V +2 10/15/14, 21:19
-
Markus Klein merged patch set 5 10/15/14, 21:19
-
Markus Klein commented on patch set 6 10/15/14, 21:19
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 0f60c0b8c2e871cf0749b0194d9cdfac772951b2 -
Markus Klein commented on patch set 6 10/16/14, 08:24
I'm struggling with the 6.1 backport here. Can please somebody take over? Don't forget to integrate the unit test update as well!! https://review.typo3.org/33330