Review main Merged

31934[BUGFIX] add _loadRealInstance in f:form ViewHelper

Stefan Froemken CR +2 V +2 Easy +3 −0 updated 09/20/14, 15:13

Commit message

If you edit a form containing subproperties of your domain model,
f:form VH will add some hidden fields to identify your related
domain models (__identity).
But in case of @lazy annotations, these fields will not be
rendered because of a missing _loadRealInstance call 
in AbstractFormViewHelper object.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Markus Klein +1
    • Frank Nägler +1
  • Verified V +2
    • Anja Leichsenring +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 15

  1. Stefan Froemken uploaded patch set 1 08/01/14, 13:05

  2. Wouter Wolters updated the commit message in patch set 2 08/01/14, 14:00

  3. Wouter Wolters updated the commit message in patch set 3 08/01/14, 14:01

  4. Wouter Wolters voted on patch set 3 CR +1 08/01/14, 14:01

  5. Markus Klein commented on patch set 3 08/01/14, 14:04

    not be rendered because of a missing
  6. Markus Klein updated the commit message in patch set 4 08/01/14, 14:05

  7. Markus Klein commented on patch set 4 CR +1 08/01/14, 14:05

    I'm not too much into this extbase stuff, but this sounds reasonable
  8. Stefan Neufeind commented on patch set 4 CR +1 08/10/14, 17:58

    imho makes sense by reading
  9. Frank Nägler voted on patch set 4 V +1 CR +1 09/17/14, 21:21

  10. Anja Leichsenring commented on patch set 4 CR -1 09/18/14, 06:00

    we can get rid of the whole _loadRealInstance() mess by merging https://review.typo3.org/#/c/32286/
  11. Stefan Froemken commented on patch set 4 09/18/14, 07:04

    Yeah...I know that ticket. But it was not tested within a minute. What about merging this patch here only for 6.2 as bugfix, and the other ticket as patch for 6.3? Deal?
  12. Stefan Neufeind commented on patch set 4 09/18/14, 07:19

    Imho let's merge it clean into 6.3/6.2 for the moment. The other patch can still get rid of the code again. But if the feature-discussion over there takes a bit longer, at least we have a consistent state.
  13. Anja Leichsenring commented on patch set 4 CR +2 V +2 09/20/14, 15:13

    fine for now
  14. Anja Leichsenring merged patch set 4 09/20/14, 15:13

  15. Anja Leichsenring commented on patch set 5 09/20/14, 15:13

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 5411e5f6d71daa4342c26eaae7ad1ec10a12a5e1