Review main Merged

32000[BUGFIX] Make sure all new files are indexed

Frans Saris CR +2 V +2 Easy +8 −4 updated 08/20/14, 11:02

Commit message

If the FAL indexer scheduler task finds a index record with
same content hash as a new found file the file isn't added to the
index if it isn't marked as missing.

This patch changes the indexer so that new files with same
content hash are added when no index record is found for a missing
file with same content hash.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Frank Nägler +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 11

  1. Frans Saris uploaded patch set 1 08/05/14, 14:20

  2. Frank Nägler commented on patch set 1 CR +1 V +1 08/05/14, 14:49

    great, works perfect
  3. Markus Klein commented on patch set 1 CR +1 08/19/14, 17:30

    Indexer.php:179

    !empty() is faster
  4. Wouter Wolters commented on patch set 1 08/19/14, 22:13

    Indexer.php:179 Reply

    +1
  5. Frans Saris uploaded patch set 2 08/20/14, 10:22

  6. Frans Saris commented on patch set 1 08/20/14, 10:23

    Indexer.php:179 Reply

    Done
  7. Frank Nägler commented on patch set 2 V +1 CR +1 08/20/14, 10:34

    looks good and work as expected :)
  8. Wouter Wolters voted on patch set 2 CR +1 08/20/14, 10:41

  9. Markus Klein voted on patch set 2 CR +2 V +2 08/20/14, 11:02

  10. Markus Klein merged patch set 2 08/20/14, 11:02

  11. Markus Klein commented on patch set 3 08/20/14, 11:02

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit b5342a8a6681965bbf5cb69090367f73ea9cff20