Review main Merged

32064[BUGFIX] Use FE category collection for pages

Francois Suter CR +2 V +2 Easy +1 −1 updated 09/09/14, 15:06

Commit message

Class CategoryMenuUtility which is used when rendering a list
of categorized pages calls on
\TYPO3\CMS\Core\Category\Collection\CategoryCollection
to collect the pages. This is wrong in a FE context as all
pages will be collected (hidden, deleted, workspace copies, etc.).
It must use
\TYPO3\CMS\Frontend\Category\Collection\CategoryCollection
instead.

Review

  • Code review CR +2
    • Francois Suter +2
    • Tomita Militaru +1
    • Tomas Norre Mikkelsen +1
    • Fabien Udriot +1
    • Nicole Hummel +1
  • Verified V +2
    • Francois Suter +2
    • Fabien Udriot +1

Issues 1

Files 1

Review log 7

  1. Francois Suter uploaded patch set 1 08/08/14, 13:13

  2. Tomita Militaru voted on patch set 1 CR +1 08/08/14, 13:28

  3. Tomas Norre Mikkelsen voted on patch set 1 CR +1 08/18/14, 07:37

  4. Fabien Udriot commented on patch set 1 V +1 CR +1 09/09/14, 14:24

    To verify: * Create a Content Element "special menu" * Select menu type "Pages for selected Categories" * Categorize a few pages -> pages start appearing in the menu. * Delete one of the categorized page -> the deleted page is still shown. * Apply the patch -> the page is removed from the menu.
  5. Nicole Hummel voted on patch set 1 CR +1 09/09/14, 14:36

  6. Francois Suter commented on patch set 1 CR +2 V +2 09/09/14, 15:06

    Thanks for the reviews. Officially it would need an additional Verified +1, but it is really trivial, so I'm going ahead.
  7. Francois Suter merged patch set 1 09/09/14, 15:06