Review main Merged

3217[TASK] Move XLIFF handling to t3lib

Xavier Perseguers CR +2 V +2 Normal +72 −81 updated 06/03/13, 20:49

Commit message

All XLIFF code should better be located within t3lib.

Review

  • Code review CR +2
    • Xavier Perseguers +2
  • Verified V +2
    • Xavier Perseguers +2

Issues 1

Files 18

Review log 16

  1. Gerrit wrote 07/11/11, 14:14

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Xavier Perseguers uploaded patch set 2 07/11/11, 14:14

  3. Xavier Perseguers commented on patch set 2 07/11/11, 14:14

    Rebase with current master
  4. Georg Ringer commented on patch set 1 07/11/11, 14:14

    Verified; Looks good to me, approved IMO go on!
  5. Georg Ringer commented on patch set 2 07/11/11, 14:14

    Verified; Looks good to me, but someone else must approve
  6. Xavier Perseguers commented on patch set 3 07/11/11, 14:14

    Looks good to me, but someone else must approve Thanks for your changes in phpDoc
  7. Xavier Perseguers uploaded patch set 4 07/11/11, 14:14

  8. Georg Ringer commented on patch set 3 V 0 07/11/11, 14:14

    by team member; Looks good to me, approved
  9. Dominique Feyer commented on patch set 3 07/11/11, 14:14

    Verified; Looks good to me, but someone else must approve Small change, an extension was not correctly refactored and some PHPdoc too. This one work with the current core, I do some test with and without language pack for extension, and everything is OK.
  10. Dominique Feyer uploaded patch set 3 07/11/11, 14:14

  11. Mr. Jenkins commented on patch set 1 07/11/11, 14:14

  12. Mr. Jenkins commented on patch set 2 07/11/11, 14:14

  13. Mr. Jenkins commented on patch set 3 07/11/11, 14:14

  14. Mr. Jenkins commented on patch set 4 07/11/11, 14:14

  15. Xavier Perseguers commented on patch set 4 V 0 07/11/11, 14:14

    by team member; Looks good to me, approved Same as patchset 3 (with enough +1's) but fixing the conflict introduced by https://review.typo3.org/#change,publish,3242,6
  16. Xavier Perseguers merged patch set 4 07/11/11, 14:14