Review main Merged

32276[BUGFIX] Fix broken form wizard with MSIE

Romain Leleu CR +2 V +2 Easy +5 −3 updated 12/11/14, 16:16

Commit message

When "Behavior / Confirmation page" checkbox is checked in a
form content, MSIE fails to show the fields in right panel.
Hovering right panel's fields shows an empty blue box and an empty tooltip.
This bug only occurs when reloading forms with the checkbox enabled
or when enabling the checkbox.

This patch fixes a JS function that sets the value and then refreshes
the right panel when clicking on one of this kind of elements.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 13

  1. Romain Leleu uploaded patch set 1 08/20/14, 14:08

  2. Romain Leleu updated the commit message in patch set 2 08/20/14, 14:15

  3. Markus Klein updated the commit message in patch set 3 08/20/14, 14:42

  4. Markus Klein commented on patch set 3 CR -1 08/20/14, 14:44

    Please improve the commit message. It should explain what is changed with the patch. I already added the new title and I added 6.3, since this is for the master branch.
    Please describe what the patch changes.
  5. Romain Leleu updated the commit message in patch set 4 08/20/14, 15:03

  6. Markus Klein updated the commit message in patch set 5 08/20/14, 16:12

  7. Markus Klein commented on patch set 5 CR +1 08/20/14, 16:13

    Thank you!
  8. Markus Klein updated the commit message in patch set 6 11/05/14, 00:35

  9. Markus Klein commented on patch set 6 CR +2 V +2 11/05/14, 09:03

    FYI 6 hours
  10. Markus Klein merged patch set 6 11/12/14, 20:08

  11. Markus Klein commented on patch set 7 11/12/14, 20:08

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit f63d65f72ac722e3e63a8b905f2b12dd98e3b478
  12. Markus Klein commented on patch set 7 12/11/14, 16:15

    This causes a regression, see https://forge.typo3.org/issues/63767
  13. Markus Klein commented on patch set 7 12/11/14, 16:16

    Reverted This patchset was reverted in change: I68306d71c8efcd055482a1da6f95005dfea6cb0e