32319[BUGFIX] Fix warning in CollectionValidator
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 9
-
Helmut Hummel uploaded patch set 1 08/22/14, 14:36
-
Markus Klein commented on patch set 1 CR +1 08/22/14, 14:47
master -> 6.3 The decision is not made yet... -
Helmut Hummel updated the commit message in patch set 2 08/22/14, 14:48
-
Wouter Wolters updated the commit message in patch set 3 08/22/14, 14:51
-
Wouter Wolters commented on patch set 3 CR +1 08/22/14, 14:52
Fixed a typo in the commit message waring -> warning -
Markus Klein voted on patch set 3 CR +1 08/22/14, 14:56
-
Markus Klein commented on patch set 3 CR 0 09/04/14, 22:54
I've to take my vote back. $acceptsEmptyValues is described as: If this is TRUE, the validators isValid() method is not called in case of an empty value. So where is that direct call? This call should be fixed. -
Anja Leichsenring commented on patch set 3 12/13/14, 14:55
not needed anymore, as the old property mapper was removed with CMS7. -
Helmut Hummel abandoned the change 12/13/14, 15:14
not worth fixing the old stuff