Review main Merged

32361[BUGFIX] Bring datetime picker time fields back in IE10+

Nikola Stojiljković CR +2 V +2 Easy +5 −1 updated 11/10/14, 20:48

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Jigal van Hemert +2
  • Verified V +2
    • Markus Klein +2
    • Jigal van Hemert +2

Issues 1

Files 1

Review log 9

  1. Nikola Stojiljković uploaded patch set 1 08/25/14, 20:51

  2. Markus Klein updated the commit message in patch set 2 08/26/14, 00:04

  3. Markus Klein commented on patch set 2 08/26/14, 00:05

    I can't really vote for the code review as I have absolutely no clue what this JS part is about. (no ExtJS knowledge)
  4. Nikola Stojiljković commented on patch set 2 11/05/14, 06:06

    You can just test it visually then :) This is not a big change, it moves fields buttons few pixels up/down in variety of browsers, but it didn't look perfect before either. This is just a quick fix for the newer IE browsers as the date picker completely broken there.
  5. Markus Klein updated the commit message in patch set 3 11/05/14, 08:53

  6. Markus Klein voted on patch set 3 CR +2 V +2 11/05/14, 09:01

  7. Jigal van Hemert commented on patch set 3 CR +2 V +2 11/08/14, 16:19

    Tested in IE11 (win 8.1) and FF. It was about the time fields in the datepicker.
  8. Jigal van Hemert merged patch set 3 11/08/14, 16:19

  9. Jigal van Hemert commented on patch set 4 11/10/14, 20:48

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 1eeee2603b567483762aaa6537246add97435404