32372[FEATURE] Allow svg files as image format for extension icons
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
-
Verified V +2
- Anja Leichsenring +2
- Wouter Wolters +1
Issues 1
Files 2
Review log 27
Show 2 earlier messages
-
Markus Klein commented on patch set 1 08/26/14, 10:31
Why do we limit the extension at all? AFAIK this is not the only place where we have that check.6.3 please -
Ingo Pfennigstorf updated the commit message in patch set 2 08/26/14, 10:32
-
Ingo Pfennigstorf commented on patch set 2 08/26/14, 10:38
Markus, this is a little odd, because in \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule() you are already able to specify an extension icon such as 'icon' => 'EXT:' . $_EXTKEY . '/ext_icon.svg', but the extension manager and this special method don't respect it. Another idea is to either patch the em to respect the settings from registerModule or to restrict it to the settings in [GFX][imagefile_ext] which currently holds 'gif,jpg,jpeg,tif,tiff,bmp,pcx,tga,png,pdf,ai' and add svg to id … -
Markus Klein commented on patch set 2 08/26/14, 10:42
I opt for using the existing setting then. -
Ingo Pfennigstorf uploaded patch set 3 08/26/14, 10:54
-
Felix Kopp commented on patch set 3 08/27/14, 00:56
I like the approach! I see no need to limit the extension icon image types. Must test later -
Tymoteusz Motylewski commented on patch set 3 CR +1 V +1 09/07/14, 13:34
tested with jpg ext_icon -
Anja Leichsenring commented on patch set 3 CR +1 09/08/14, 09:54
can we please have documentation in typo3/sysext/core/Documentation? After this is a feature, it need doc entry, so it will not get lost. Otherwise fine, ready to merge IMHO. -
Christian Kuhn commented on patch set 3 CR -1 09/08/14, 10:12
Actually, I'd prefer to stick to the version of patch set 2, since imho imagefile_ext is a misuse of the option. See comment for details.ExtensionManagementUtility.php:1475isn't this mixing up the purpose of imagefile_ext? If i see it correctly, imagefile_ext is used in the graphics handler as a list of file types that can be converted to something that can be rendered by a browser directly. That why pdf and ai are included in this option, even if they can not be displayed directly in the browser. Here, we only want specific types of files that can be directly rendered in the browser without a conversion step. Thus, using imagefile_ext option here would be a misuse. Maybe it would be better to just extend the hardcoded list here if svg should be supported as possible file type here at this point? -
Stefan Neufeind commented on patch set 3 CR -1 09/12/14, 16:00
I agree with Christian that I'd also prefer changeset 2 since using the imageext-setting would be a "misuse". But if we add "svg" there, there is no real reason why we also don't add "jpg" and "jpeg" and whatever as well. Is it needed here to limit by fileextension at all? -
Tymoteusz Motylewski commented on patch set 3 CR 0 V 0 09/12/14, 22:15
so maybe we should drop the check at all? Just look for the first file called ext_icon.* and take it and don't care about it's extension? -
Stefan Neufeind commented on patch set 3 09/14/14, 08:43
I'm +1 for ext_icon.* (remove the extension-check). -
Felix Kopp commented on patch set 3 09/14/14, 10:43
Thank you for the patches! I would like to picke Patchset (2) with clear extension constraints. Also I would like to recommend using .PNG to the extension authors only. We have to think about the extension manager, TER/composer/Packagist and CMS backend. Why we have to decide: Currently composer does not define a standard how to define an Icon for a composer package = TYPO3 extension. We lead the discussion here. The extension icon is necessary and should be sent in multiple *sizes*: for the backend and for the TER/Marketplace. Android: PNG, JPG, GIF Apple: PNG See how Apple does this: https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/AppIcons.html See how Android does this: http://developer.android.com/design/style/iconography.html and http://developer.android.com/guide/topics/resources/providing-resources.html -
Benni Mack commented on patch set 3 09/19/14, 12:52
ExtensionManagementUtility.php:1475Replyi 100% agree! -
Andreas Kienast commented on patch set 3 09/19/14, 14:11
ExtensionManagementUtility.php:1478is_file is safer. file_exists also returns TRUE if the file is a directory. -
Stefan Neufeind commented on patch set 3 09/19/14, 14:14
ExtensionManagementUtility.php:1478ReplyBut is_file doesn't work for symlinks - though I don't think that would be a problem in this special case. (You could still symlink a full ext-folder, just not one file.) -
Stefan Froemken commented on patch set 3 09/19/14, 20:49
ExtensionManagementUtility.php:1478ReplyAnd what about working with realpath: http://php.net/manual/de/function.realpath.php -
Ingo Pfennigstorf uploaded patch set 4 09/20/14, 11:52
-
Ingo Pfennigstorf uploaded patch set 5 09/20/14, 11:53
-
Ingo Pfennigstorf uploaded patch set 6 09/20/14, 12:04
-
Stefan Neufeind commented on patch set 6 09/20/14, 12:13
ExtensionManagementUtility.php:1475It might be a nitpick, but why did you choose that order? It's not alphabetic and not svg added after the existing entries or something. -
Wouter Wolters voted on patch set 6 V +1 CR +1 09/20/14, 12:17
-
Ingo Pfennigstorf commented on patch set 6 09/20/14, 12:18
ExtensionManagementUtility.php:1475ReplyJust because of my personal impression that gif files are quite outdated (except for funny social network animated stuff). png at first place, because it has been like that and is backed by Felix's statement regarding iOS and Android … -
Anja Leichsenring voted on patch set 6 CR +2 V +2 10/02/14, 15:05
-
Anja Leichsenring merged patch set 6 10/02/14, 15:06