32441[BUGFIX] Fix clear_cache for XCache < 3.0
Commit message
Review
-
Code review CR +2
- Markus Klein +2
-
Verified V +2
- Markus Klein +2
Issues 1
Files 1
Review log 9
-
Alexander Opitz uploaded patch set 1 08/27/14, 16:09
-
Markus Klein commented on patch set 1 08/27/14, 20:22
-
Alexander Opitz commented on patch set 1 08/28/14, 12:26
OpcodeCacheUtility.php:118ReplyYes, we can do, but I thought we do not need to do this check on every closure call. On the other side we don't call this closure on every load ... should I change? -
Markus Klein commented on patch set 1 CR +1 08/28/14, 14:16
OpcodeCacheUtility.php:118ReplyGood point actually. Let's leave it like this. Thx -
Markus Klein commented on patch set 1 09/04/14, 22:40
Are we sure this construct (ternary returning closure within array definition) also works on PHP 5.3? -
Mathias Brodala commented on patch set 1 09/08/14, 09:17
OpcodeCacheUtility.php:44We're not writing C, be brave and name this $xCacheVersion. ;-) -
Markus Klein commented on patch set 1 CR +2 V +2 09/08/14, 09:59
Tested by Philipp on a live system with PHP 5.3 -
Markus Klein merged patch set 1 09/08/14, 09:59
-
Markus Klein commented on patch set 2 09/08/14, 10:00
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 5b6a4ce5d298dcb52f3ddc5c4836014a6bd36d80
OpcodeCacheUtility.php:118