Review main Merged

32441[BUGFIX] Fix clear_cache for XCache < 3.0

Alexander Opitz CR +2 V +2 Easy +18 −6 updated 09/08/14, 10:00

Commit message

The XCache API changed with version 3.0. Ubuntu 12.04 uses XCache
version 1.3.2 so we need to support the old API.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 9

  1. Alexander Opitz uploaded patch set 1 08/27/14, 16:09

  2. Markus Klein commented on patch set 1 08/27/14, 20:22

    OpcodeCacheUtility.php:118

    can't we do this check inside the closure? Currently we duplicate the whole function
  3. Alexander Opitz commented on patch set 1 08/28/14, 12:26

    OpcodeCacheUtility.php:118 Reply

    Yes, we can do, but I thought we do not need to do this check on every closure call. On the other side we don't call this closure on every load ... should I change?
  4. Markus Klein commented on patch set 1 CR +1 08/28/14, 14:16

    OpcodeCacheUtility.php:118 Reply

    Good point actually. Let's leave it like this. Thx
  5. Markus Klein commented on patch set 1 09/04/14, 22:40

    Are we sure this construct (ternary returning closure within array definition) also works on PHP 5.3?
  6. Mathias Brodala commented on patch set 1 09/08/14, 09:17

    OpcodeCacheUtility.php:44

    We're not writing C, be brave and name this $xCacheVersion. ;-)
  7. Markus Klein commented on patch set 1 CR +2 V +2 09/08/14, 09:59

    Tested by Philipp on a live system with PHP 5.3
  8. Markus Klein merged patch set 1 09/08/14, 09:59

  9. Markus Klein commented on patch set 2 09/08/14, 10:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 5b6a4ce5d298dcb52f3ddc5c4836014a6bd36d80