Review main Merged

32458[TASK] Remove class.tslib_pagegen.php from EXT:cms/tslib

Wouter Wolters CR +2 V +2 Easy +3 −39 updated 09/03/14, 10:35

Commit message

Class is unused and contains code that is deprecated and
marked for removal in TYPO3 CMS 6.3

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Opitz +1

Issues 1

Files 3

Review log 10

  1. Wouter Wolters uploaded patch set 1 08/27/14, 19:15

  2. Markus Klein commented on patch set 1 08/27/14, 20:20

    Reference to this file also in comment line in typo3/sysext/frontend/Classes/ContentObject/SearchResultContentObject.php Rest looks clean.
  3. Wouter Wolters uploaded patch set 2 09/01/14, 20:06

  4. Alexander Opitz voted on patch set 2 V +1 CR +1 09/02/14, 07:08

  5. Wouter Wolters commented on patch set 2 CR -1 09/02/14, 09:23

    Will fix asap..

    SearchResultContentObject.php:21

    My bad this is wrong, should be the content object renderer
  6. Wouter Wolters uploaded patch set 3 09/02/14, 18:39

  7. Markus Klein voted on patch set 3 V +1 CR +1 09/02/14, 20:14

  8. Alexander Opitz voted on patch set 3 V +1 CR +1 09/03/14, 07:35

  9. Markus Klein voted on patch set 3 CR +2 V +2 09/03/14, 10:35

  10. Markus Klein merged patch set 3 09/03/14, 10:35