Review main Merged

32511[TASK] Move backend module icons to respective location

Felix Kopp CR +2 V +2 Normal +35 −42 updated 09/07/14, 19:34

Commit message

In TYPO3 CMS world each extension contains multiple icons:

+ "extension icons" (ext_icon.gif) to identify the whole extension (EM/TER)
+ "module icon" as Start button per backend module (module menu)
+ "record icons" in recordlist as clickmenu link
+ "action icons" like save, close or info (toolbar)

Currently all icons look the same in the backend (16x16 pixels, same theme).
Also many icon files are used multiple ways (e.g. ext_icon.gif as module icon).

In order to be able to differentiate icons better by their primary function
this patch introduces a common folder as defined location for backend
module icon files and demontrastes a naming schema "module-name.xxx".

Also this patch reduces cohesion and coupling of backend extensions since
extensions now bring their own icons in a predictable fashion.

This supports alternative backends that do not rely on t3skin at all.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Anja Leichsenring +2
    • Tymoteusz Motylewski +1

Issues 1

Files 61

Show 41 more files

Review log 7

  1. Felix Kopp uploaded patch set 1 08/29/14, 12:03

  2. Felix Kopp uploaded patch set 2 08/29/14, 12:13

  3. Christian Kuhn voted on patch set 2 CR +1 09/06/14, 19:57

  4. Tymoteusz Motylewski voted on patch set 2 CR +1 V +1 09/07/14, 11:43

  5. Felix Kopp commented on patch set 2 09/07/14, 17:35

    Please check & merge :) Thank you!
  6. Anja Leichsenring voted on patch set 2 CR +2 V +2 09/07/14, 19:34

  7. Anja Leichsenring merged patch set 2 09/07/14, 19:34