3257[FEATURE] Add hashing algorithms to stdWrap
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
-
Verified V +2
- Xavier Perseguers +2
- Stefan Neufeind +1
Issues 1
Files 2
Review log 25
-
Fabrizio Branca uploaded patch set 2 07/12/11, 13:15
-
Xavier Perseguers commented on patch set 1 07/12/11, 13:15
I would prefer that you didn't submit this Please remove the dependency you have in your commit with the other patch.Cut this long comment on two lines pleaseclass.tslib_content.php:122We need 'hash.' too to be able to do fancy stuff such as hash = TEXT hash.value = sha1class.tslib_content.php:2331Will return a hashed Seems to me that it's "a" and not "an"class.tslib_content.php:2338array $conf = array()class.tslib_content.php:2341should have stdWrap support, not cObj actually -
Xavier Perseguers commented on patch set 1 07/12/11, 13:15
(1 inline comment) -
Xavier Perseguers uploaded patch set 3 07/12/11, 13:15
-
Xavier Perseguers commented on patch set 3 1 comment 07/12/11, 13:15
No score -
Xavier Perseguers commented on patch set 3 07/12/11, 13:15
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 4 07/12/11, 13:15
Looks good to me, but someone else must approve CGL needs to be fixed. But other than that looks okay to me -
Xavier Perseguers uploaded patch set 4 07/12/11, 13:15
-
Xavier Perseguers commented on patch set 4 07/12/11, 13:15
Verified; Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 4 3 comments 07/12/11, 13:15
No score -
Stefan Neufeind commented on patch set 5 07/12/11, 13:15
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 5 07/12/11, 13:15
But please don't hardcode it. Maybe fetch as singleton via hash_algos()? -
Xavier Perseguers commented on patch set 5 07/12/11, 13:15
Verified; Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 5 V 0 07/12/11, 13:15
by team member; Looks good to me, approved -
Xavier Perseguers commented on patch set 5 07/12/11, 13:15
Please open an issue on Forge related to this change if you want to change something. -
Xavier Perseguers uploaded patch set 5 07/12/11, 13:15
-
Xavier Perseguers merged patch set 5 07/12/11, 13:15
-
Georg Ringer commented on patch set 4 07/12/11, 13:15
I would prefer that you didn't submit thisclass.tslib_content.php:2331either write a complete line or remove the word "hash"class.tslib_content.php:2333isnt there a annotation for that, like @see or @url or so?class.tslib_content.php:2335CGL no tabs but spaces -
Chris topher commented on patch set 5 07/12/11, 13:15
(1 inline comment) Would be nice, if you could still add a check for $algorithm holding the value of an available algorithm (and otherwise use a default). This can prevent PHP errors.class.tslib_content.php:2341Could you still add a check if $algorithm contains a value, which is present as a hashing algorithm on the system? If it is not, this will give an error... -
Mr. Jenkins commented on patch set 1 07/12/11, 13:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1114/ : SUCCESS -
Mr. Jenkins commented on patch set 2 07/12/11, 13:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1116/ : SUCCESS -
Mr. Jenkins commented on patch set 3 07/12/11, 13:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1118/ : SUCCESS -
Mr. Jenkins commented on patch set 4 07/12/11, 13:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1121/ : SUCCESS -
Mr. Jenkins commented on patch set 5 07/12/11, 13:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1126/ : SUCCESS -
Chris topher commented on patch set 5 07/12/11, 13:15
OK, I have created #28120.