Review main Merged

3257[FEATURE] Add hashing algorithms to stdWrap

Fabrizio Branca CR +2 V +2 Normal +87 −2 updated 06/03/13, 20:49

Commit message

Enable hashing the content through stdWrap using different hashing algorithms

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
  • Verified V +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1

Issues 1

Files 2

Review log 25

  1. Fabrizio Branca uploaded patch set 2 07/12/11, 13:15

  2. Xavier Perseguers commented on patch set 1 07/12/11, 13:15

    I would prefer that you didn't submit this Please remove the dependency you have in your commit with the other patch.
    Cut this long comment on two lines please

    class.tslib_content.php:122

    We need 'hash.' too to be able to do fancy stuff such as hash = TEXT hash.value = sha1

    class.tslib_content.php:2331

    Will return a hashed Seems to me that it's "a" and not "an"

    class.tslib_content.php:2338

    array $conf = array()

    class.tslib_content.php:2341

    should have stdWrap support, not cObj actually
  3. Xavier Perseguers commented on patch set 1 07/12/11, 13:15

    (1 inline comment)
  4. Xavier Perseguers uploaded patch set 3 07/12/11, 13:15

  5. Xavier Perseguers commented on patch set 3 1 comment 07/12/11, 13:15

    No score
  6. Xavier Perseguers commented on patch set 3 07/12/11, 13:15

    Verified; Looks good to me, but someone else must approve
  7. Stefan Neufeind commented on patch set 4 07/12/11, 13:15

    Looks good to me, but someone else must approve CGL needs to be fixed. But other than that looks okay to me
  8. Xavier Perseguers uploaded patch set 4 07/12/11, 13:15

  9. Xavier Perseguers commented on patch set 4 07/12/11, 13:15

    Verified; Looks good to me, but someone else must approve
  10. Xavier Perseguers commented on patch set 4 3 comments 07/12/11, 13:15

    No score
  11. Stefan Neufeind commented on patch set 5 07/12/11, 13:15

    Verified; Looks good to me, but someone else must approve
  12. Stefan Neufeind commented on patch set 5 07/12/11, 13:15

    But please don't hardcode it. Maybe fetch as singleton via hash_algos()?
  13. Xavier Perseguers commented on patch set 5 07/12/11, 13:15

    Verified; Looks good to me, but someone else must approve
  14. Xavier Perseguers commented on patch set 5 V 0 07/12/11, 13:15

    by team member; Looks good to me, approved
  15. Xavier Perseguers commented on patch set 5 07/12/11, 13:15

    Please open an issue on Forge related to this change if you want to change something.
  16. Xavier Perseguers uploaded patch set 5 07/12/11, 13:15

  17. Xavier Perseguers merged patch set 5 07/12/11, 13:15

  18. Georg Ringer commented on patch set 4 07/12/11, 13:15

    I would prefer that you didn't submit this

    class.tslib_content.php:2331

    either write a complete line or remove the word "hash"

    class.tslib_content.php:2333

    isnt there a annotation for that, like @see or @url or so?

    class.tslib_content.php:2335

    CGL no tabs but spaces
  19. Chris topher commented on patch set 5 07/12/11, 13:15

    (1 inline comment) Would be nice, if you could still add a check for $algorithm holding the value of an available algorithm (and otherwise use a default). This can prevent PHP errors.

    class.tslib_content.php:2341

    Could you still add a check if $algorithm contains a value, which is present as a hashing algorithm on the system? If it is not, this will give an error...
  20. Mr. Jenkins commented on patch set 1 07/12/11, 13:15

  21. Mr. Jenkins commented on patch set 2 07/12/11, 13:15

  22. Mr. Jenkins commented on patch set 3 07/12/11, 13:15

  23. Mr. Jenkins commented on patch set 4 07/12/11, 13:15

  24. Mr. Jenkins commented on patch set 5 07/12/11, 13:15

  25. Chris topher commented on patch set 5 07/12/11, 13:15

    OK, I have created #28120.