Review main Merged

3259[TASK] Clean-up round() stdWrap implementation

Xavier Perseguers CR +2 V +2 Easy +5 −5 updated 06/03/13, 20:49

Commit message

- Rework PHP documentation to be in-line with other methods
- Declare the method as protected instead of private to allow subclassing
- Add array type to argument $conf

Review

  • Code review CR +2
    • Xavier Perseguers +2
  • Verified V +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 3

  1. Mr. Jenkins commented on patch set 1 07/11/11, 19:58

  2. Xavier Perseguers commented on patch set 1 V 0 07/11/11, 19:58

    by team member; Looks good to me, approved Nobrainer
  3. Xavier Perseguers merged patch set 1 07/11/11, 19:58