32611[TASK] Remove class aliases part 1
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 36
- typo3/sysext/about/Classes/Domain/Repository/ExtensionRepository.php+2 −3
- typo3/sysext/about/Migrations/Code/ClassAliasMap.phpdeleted+0 −7
- typo3/sysext/aboutmodules/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/core/Migrations/Code/LegacyClassesForIde.php+0 −1134
- typo3/sysext/dbal/Migrations/Code/ClassAliasMap.phpdeleted+0 −8
- typo3/sysext/extensionmanager/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/extra_page_cm_options/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/feedit/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/filelist/Migrations/Code/ClassAliasMap.php+0 −3
- typo3/sysext/func/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/func_wizards/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/impexp/Migrations/Code/ClassAliasMap.php+0 −3
- typo3/sysext/info/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/info_pagetsconfig/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/install/Migrations/Code/ClassAliasMap.php+0 −22
- typo3/sysext/linkvalidator/Migrations/Code/ClassAliasMap.phpdeleted+0 −13
- typo3/sysext/lowlevel/Migrations/Code/ClassAliasMap.php+0 −12
- typo3/sysext/opendocs/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/openid/Migrations/Code/ClassAliasMap.php+0 −4
- typo3/sysext/perm/Migrations/Code/ClassAliasMap.phpdeleted+0 −5
Show 16 more files
- typo3/sysext/recordlist/Migrations/Code/ClassAliasMap.php+0 −3
- typo3/sysext/recycler/Migrations/Code/ClassAliasMap.phpdeleted+0 −9
- typo3/sysext/reports/Migrations/Code/ClassAliasMap.phpdeleted+0 −17
- typo3/sysext/rsaauth/Migrations/Code/ClassAliasMap.php+0 −13
- typo3/sysext/rtehtmlarea/Migrations/Code/ClassAliasMap.php+0 −43
- typo3/sysext/saltedpasswords/Migrations/Code/ClassAliasMap.php+0 −4
- typo3/sysext/scheduler/Migrations/Code/ClassAliasMap.php+0 −16
- typo3/sysext/sv/Migrations/Code/ClassAliasMap.php+0 −3
- typo3/sysext/sys_action/Migrations/Code/ClassAliasMap.php+0 −2
- typo3/sysext/t3editor/Migrations/Code/ClassAliasMap.php+0 −5
- typo3/sysext/taskcenter/Migrations/Code/ClassAliasMap.phpdeleted+0 −6
- typo3/sysext/tstemplate/Migrations/Code/ClassAliasMap.php+0 −3
- typo3/sysext/version/Migrations/Code/ClassAliasMap.php+0 −12
- typo3/sysext/wizard_crpages/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/wizard_sortpages/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/workspaces/Migrations/Code/ClassAliasMap.phpdeleted+0 −26
Review log 7
-
Christian Kuhn uploaded patch set 1 09/06/14, 18:18
-
Markus Klein commented on patch set 1 09/06/14, 23:41
What's the benefit of removing them? How big is the speed improvement? This finally breaks an enormous amount of extensions, is it really necessary to do this change? We don't gain any functionality by removing those aliases.We did not decide yet on the blueprint, so please stick to the old rules. Besides that I'm still not sure about only using "master" here. Lets say this "master" will be 7.0 finally. This commit will also be part of 8.0 ff then. How do you know in 10.0 which version actually introduced this commit? Do I have to search all branches then? -
Christian Kuhn commented on patch set 1 09/07/14, 07:56
Not creating all those alias files in the cache framework for the classes cache lets the system create only half of the number of files. this is significant on non ssd systems.Reply
Deciding on the blueprint is long overdue. I will act as if it is accepted. -
Tymoteusz Motylewski commented on patch set 1 09/07/14, 12:19
maybe the solution would be to move aliases to the separate extensions, and ship it in the TER ? -
Christian Kuhn commented on patch set 1 09/07/14, 16:42
Hmm, moving those aliases to an extension is maybe a good idea, so people may load this if they still did not search-replace their old extensions. So task is to move those ClassAliasMap.php files to a single new extension like "ClassAliasCompatibility", search for each and every class name and look for still existing mentions in the core, and move the Lecacy file over to this extension. Then upload this extension to a forge ticket and let the core team handle the TER upload unter the "meta" username of core team. Then delete the extension from core together with a documentation entry. Maybe even create an upgrade wizard to fetch this TER extension, so an admin can do that during upgrading. Since this all will take way more hours than I'm currently willing to spend in this area, I'll abandon this patch for now and will hope for someone else taking care of this. -
Christian Kuhn commented on patch set 1 09/07/14, 16:52
Additionally, I'm not really in favor of having such an extension, since it gives us additional b/w issues. This extension then may need to be maintained and 3rd party extension that need this compat thingie need to be adapted. If we create such an extension, I'd strongly opt for NOT officially declaring maintenance by the core team towards this one. It MUST be very clear that any extension requiring this compat layer is rotten and not fully compatible with the core. -
Christian Kuhn abandoned the change 09/07/14, 16:53
abandoned.