Review main Merged

32616[BUGFIX] Remove PHP warnings when no icon is found in FormEngine

Benni Mack CR +2 V +2 Easy +11 −5 updated 09/16/14, 12:52

Commit message

If running in development mode and an icon
in FormEngine is not found, TYPO3 shows
the PHP E_WARNING of getimagesize() in a flash message.

The check should therefore be done in a cleaner way,
without the @ symbol.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 6

  1. Benni Mack uploaded patch set 1 09/07/14, 15:24

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 09/07/14, 19:38

  3. Anja Leichsenring voted on patch set 1 CR +2 V +2 09/07/14, 19:58

  4. Anja Leichsenring merged patch set 1 09/07/14, 20:11

  5. Anja Leichsenring commented on patch set 2 09/07/14, 20:12

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 18c033d2a33283eb123c8af38d6efe65d40f09de
  6. Nicole Hummel commented on patch set 2 09/16/14, 12:52

    POST -1 as file_exists is true for folders as well but getimagesize can't handle folders. Will push an update