Review main Merged

32617[TASK] Use SpriteIcon for Add icon in Scheduler

Felix Kopp CR +2 V +2 Easy +1 −1 updated 09/07/14, 19:26

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 8

  1. Felix Kopp uploaded patch set 1 09/07/14, 17:40

  2. Felix Kopp commented on patch set 1 09/07/14, 17:40

    SchedulerModuleController.php:1532

    Alt or Title?
  3. Christian Kuhn commented on patch set 1 09/07/14, 19:08

    SchedulerModuleController.php:1532 Reply

    alt please, since alt attribute is mandatory on img. for title, the title attribute of the surrounding a href is shown anyway.
  4. Christian Kuhn uploaded patch set 2 09/07/14, 19:11

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 09/07/14, 19:12

  6. Wouter Wolters voted on patch set 2 V +2 CR +2 09/07/14, 19:26

  7. Wouter Wolters merged patch set 2 09/07/14, 19:26

  8. Wouter Wolters commented on patch set 3 09/07/14, 19:26

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 81ce58c5eed0379b95fb2ba88bef732a9204c8f2