Review main Merged

32645[BUGFIX] Check TBE_STYLES skins for being an array

Georg Ringer CR +2 V +2 Easy +4 −2 updated 09/08/14, 21:03

Commit message

If no skinning extension is installed, an exception is thrown which
makes it impossible to use the system. Therefore the variable must
be checked.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Xavier Perseguers +1
    • Stefan Froemken +1
  • Verified V +2
    • Christian Kuhn +2
    • Xavier Perseguers +1
    • Stefan Froemken +1

Issues 1

Files 1

Review log 5

  1. Georg Ringer uploaded patch set 1 09/08/14, 14:49

  2. Stefan Froemken commented on patch set 1 V +1 CR +1 09/08/14, 16:15

    It looks still ugly, but you're right: The Exception is gone.
  3. Xavier Perseguers voted on patch set 1 CR +1 V +1 09/08/14, 19:59

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 09/08/14, 21:02

  5. Christian Kuhn merged patch set 1 09/08/14, 21:03