32646[TASK] Move user simulation in module "user settings"
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 2
Review log 25
-
Georg Ringer uploaded patch set 1 09/08/14, 15:10
-
Benni Mack voted on patch set 1 CR +1 09/08/14, 15:51
-
Christian Kuhn uploaded patch set 2 09/08/14, 15:53
-
Christian Kuhn commented on patch set 1 09/08/14, 16:02
-
Felix Kopp voted on patch set 2 CR -1 09/08/14, 16:11
-
Helmut Hummel commented on patch set 2 CR -2 09/08/14, 16:22
It works and should not be just removed without replacement. -
Stefan Froemken commented on patch set 2 CR +1 V +1 09/08/14, 16:31
Oh dear. Again -2. Happy discussion. As Georg already mentioned we have a better implementation in "backend users". And it doesn't work since...since...Damn: Has somebody ever used this function? -
Felix Kopp uploaded patch set 3 09/08/14, 19:16
-
Felix Kopp commented on patch set 3 CR -1 09/08/14, 19:19
SqlParser :( wtf -
Xavier Perseguers voted on patch set 3 CR -2 09/08/14, 20:56
-
Felix Kopp uploaded patch set 4 09/15/14, 22:30
-
Felix Kopp uploaded patch set 5 09/15/14, 22:33
-
Oliver Hader commented on patch set 5 CR +1 09/16/14, 13:14
Better now. I never used this feature since I expected something different here... It's about modifying the user settings of another user, not to be mixed up with the simulate user login of the backend user module. Thus, making this more dominant is a good step, finding a better description e.g. "modify settings of different user"... @Stefan: The given -2s were correct to stop this issue from being merged. There is no better replacement in the backend user module, it's not possible to e.g. disable the RTE for a particular user there. -
Oliver Hader wrote 09/16/14, 13:18
Removed the following approvals: * Code-Review-2 by Xavier Perseguers <xavier@typo3.org> -
Oliver Hader wrote 09/16/14, 13:18
Removed the following approvals: * Code-Review-2 by Helmut Hummel <helmut.hummel@typo3.org> -
Oliver Hader commented on patch set 5 09/16/14, 13:19
I further removed Xavier's and Helmut's -2 to unblock this change. Both votes were given on an earlier change set that removed this particular feature or has been faulty (SqlParser). -
Felix Kopp voted on patch set 5 CR +2 V +2 09/16/14, 16:44
-
Felix Kopp commented on patch set 5 09/16/14, 16:45
Please give another rating, since I changed the patch quite a bit :) -
Wouter Wolters commented on patch set 5 CR -1 09/16/14, 16:51
Will push a fixSetupModuleController.php:682What kind of type is this... -
Wouter Wolters uploaded patch set 6 09/16/14, 17:12
-
Wouter Wolters commented on patch set 6 V +1 CR +1 09/16/14, 17:15
SetupModuleController.php:678Removed this function without deprecation because I think this is only used in the core. Correct me if this is the wrong approach. -
Markus Klein uploaded patch set 7 09/16/14, 22:27
-
Markus Klein voted on patch set 7 CR +1 V +1 09/16/14, 22:28
-
Wouter Wolters voted on patch set 7 V +2 CR +2 09/17/14, 06:54
-
Wouter Wolters merged patch set 7 09/17/14, 06:54
SetupModuleController.php:678