Review main Merged

32651[BUGFIX] One func wizard installed shows "Select wizard" without selectbox

Wouter Wolters CR +2 V +2 Easy +8 −5 updated 09/08/14, 20:22

Commit message

With one func wizard installed the text "Select wizard" is shown
without a selectbox. Hide the text if no func menu is available.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 9

  1. Wouter Wolters uploaded patch set 1 09/08/14, 16:58

  2. Stefan Froemken voted on patch set 1 CR +1 V +1 09/08/14, 17:12

  3. Xavier Perseguers commented on patch set 1 09/08/14, 19:56

    WebFunctionWizardsBaseController.php:74

    remove global

    WebFunctionWizardsBaseController.php:85

    $GLOBALS['LANG']->getLL(...
  4. Wouter Wolters commented on patch set 1 09/08/14, 19:58

    Not in scope of this patch. Follow up will be done for sure
  5. Christian Kuhn commented on patch set 1 09/08/14, 20:06

    actually, the selector should be moved to the docheader like it is done for "info" module, too.
  6. Christian Kuhn uploaded patch set 2 09/08/14, 20:11

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 09/08/14, 20:13

  8. Anja Leichsenring voted on patch set 2 CR +2 V +2 09/08/14, 20:22

  9. Anja Leichsenring merged patch set 2 09/08/14, 20:22