32697[BUGFIX] Followup to mod.SHARED.colPos_list fix
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Helmut Hummel +2
- Jo Hasenau +1
- Nicole Hummel +1
-
Verified V +2
- Jigal van Hemert +2
- Helmut Hummel +2
Issues 1
Files 1
Review log 20
-
Helmut Hummel uploaded patch set 1 09/10/14, 08:31
-
Nicole Hummel commented on patch set 1 09/10/14, 08:38
-
Helmut Hummel commented on patch set 1 09/10/14, 08:43
PageLayoutController.php:553Replytrue! -
Jo Hasenau commented on patch set 1 V -1 CR -1 09/10/14, 08:47
PageLayoutController.php:547Should be $this->colPosList = array_unique(...) to make it work -
Jo Hasenau commented on patch set 1 09/10/14, 08:51
Actually it would be enough to move the line one level up and put it into the braces of the if clause -
Jo Hasenau uploaded patch set 2 09/10/14, 08:53
-
Helmut Hummel commented on patch set 1 09/10/14, 08:53
PageLayoutController.php:546here is the typo! colActivePosList does not exist -
Jo Hasenau uploaded patch set 3 09/10/14, 08:54
-
Jo Hasenau uploaded patch set 4 09/10/14, 09:00
-
Nicole Hummel voted on patch set 4 CR +1 09/10/14, 09:04
-
Nicole Hummel commented on patch set 4 CR 0 09/10/14, 09:05
PageLayoutController.php:546do we need that line or could we simply combine both arrays anyway? -
Helmut Hummel commented on patch set 4 CR +2 V +2 09/10/14, 09:10
PageLayoutController.php:546Replythe checks do not harm and it works, I would leave it like that now -
Nicole Hummel voted on patch set 4 CR +1 09/10/14, 09:25
-
Jo Hasenau voted on patch set 4 CR +1 09/10/14, 09:26
-
Jigal van Hemert commented on patch set 4 CR +2 V +2 09/10/14, 09:56
Sorry about the typo in the original patch. The implode outside the if prevents more problems. -
Jigal van Hemert merged patch set 4 09/10/14, 09:56
-
Wouter Wolters commented on patch set 5 09/10/14, 17:18
post -1PageLayoutController.php:553This else statement is needed on my installation to have the page module working again.. On my installation $this->modSharedTSconfig['properties']['colPos_list'] = NULL -
Markus Klein commented on patch set 5 09/10/14, 17:27
PageLayoutController.php:543isset() check missing IMOPageLayoutController.php:553ReplyDoes not solve it for me. $this->modSharedTSconfig['properties'] is already NULL. -
Markus Klein commented on patch set 5 09/10/14, 17:40
Post -1 $this->activeColPosList is not initialized at all if $this->modSharedTSconfig['properties'] is NULL! -
Helmut Hummel commented on patch set 5 09/12/14, 15:57
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 600485194edaf5364821613423221bfdd57614d9
PageLayoutController.php:553