Review main Merged

32706[TASK] TemplateService: Add verbose option

Benni Mack CR +2 V +2 Easy +33 −10 updated 09/13/14, 19:53

Commit message

The TemplateService class contains the functionality
to parse the TypoScript constants that haven't
been replaced yet.

This is done each time in the frontend, although
it is only useful when $this->tt_track is active,
thus when a BE user is logged in, who can read the info.

The improvement in this patch is to skip the strstr()
check if not set, thus making first-hit page calls a bit
quicker and the code more readable.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Anja Leichsenring +2
    • Tymoteusz Motylewski +1

Issues 1

Files 2

Review log 4

  1. Benni Mack uploaded patch set 1 09/10/14, 13:58

  2. Tymoteusz Motylewski commented on patch set 1 CR +1 V +1 09/12/14, 21:32

    looks good
  3. Anja Leichsenring voted on patch set 1 CR +2 V +2 09/13/14, 19:53

  4. Anja Leichsenring merged patch set 1 09/13/14, 19:53