Review main Merged

32707[CLEANUP] Always use HSC in TS labels in BE

Benni Mack CR +2 V +2 Easy +29 −4 updated 10/06/14, 18:22

Commit message

The ExtendedTemplateService class contains
a switch "ext_noSpecialCharsOnLabels" which
is never used in the core. It is used to call a wrapper
function that simple doesn't do HSC() if the
option is set.

The method and option can be deprecated.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1

Issues 1

Files 2

Review log 8

  1. Benni Mack uploaded patch set 1 09/10/14, 14:01

  2. Benni Mack uploaded patch set 2 10/02/14, 18:38

  3. Anja Leichsenring voted on patch set 2 CR +1 V +1 10/02/14, 21:27

  4. Markus Klein commented on patch set 2 CR -1 10/02/14, 22:28

    Deprecation-61513-Remove-HSC-Function-In-Backend-TypoScript-Module.rst:2

    typo 61513

    Deprecation-61513-Remove-HSC-Function-In-Backend-TypoScript-Module.rst:9

    Is it "TS", or is it "TS labels", or something else? commit message says TS labels

    Deprecation-61513-Remove-HSC-Function-In-Backend-TypoScript-Module.rst:10

    this sentence is missing something

    Deprecation-61513-Remove-HSC-Function-In-Backend-TypoScript-Module.rst:10

    typo
  5. Benni Mack uploaded patch set 3 10/06/14, 13:42

  6. Markus Klein voted on patch set 3 CR +1 V +1 10/06/14, 13:50

  7. Georg Ringer voted on patch set 3 V +2 CR +2 10/06/14, 18:21

  8. Georg Ringer merged patch set 3 10/06/14, 18:22