32712[BUGFIX] Followup 2 to mod.SHARED.colPos_list fix
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Anja Leichsenring +1
-
Verified V +2
- Helmut Hummel +2
- Anja Leichsenring +1
Issues 1
Files 1
Review log 12
-
Jigal van Hemert uploaded patch set 1 09/10/14, 19:37
-
Markus Klein voted on patch set 1 CR +1 09/11/14, 15:23
-
Nicole Hummel commented on patch set 1 09/11/14, 16:06
-
Markus Klein commented on patch set 1 09/11/14, 16:22
PageLayoutController.php:543ReplyAttention!! colpos_list might be 0. empty is not possible here. -
Nicole Hummel commented on patch set 1 09/11/14, 21:39
PageLayoutController.php:543Replyempty() should just check if the array key exists, not checking the value! -
Anja Leichsenring voted on patch set 1 CR +1 V +1 09/12/14, 15:29
-
Helmut Hummel commented on patch set 1 09/12/14, 15:47
PageLayoutController.php:543Reply$this->modSharedTSconfig['properties']['colPos_list'] can have the value "0" empty($this->modSharedTSconfig['properties']['colPos_list']) would be true then. This is no option. But we should use isset($this->modSharedTSconfig['properties']['colPos_list']) instead of is_array($this->modSharedTSconfig['properties']) -
Helmut Hummel uploaded patch set 2 09/12/14, 15:48
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 09/12/14, 15:53
-
Helmut Hummel voted on patch set 2 CR +2 V +2 09/12/14, 15:54
-
Helmut Hummel merged patch set 2 09/12/14, 15:54
-
Helmut Hummel commented on patch set 3 09/12/14, 15:57
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit eae10514291c34d411aaf71cf0ffd0b5c758cbab
PageLayoutController.php:543