Review main Merged

32717[TASK] Split xdebug.max_nesting_level into two error levels

Nicole Hummel CR +2 V +2 Easy +15 −3 updated 09/15/14, 13:24

Commit message

The recommended xdebug.max_nesting_level was raised from 250 to
400 with issue #59391. Since the core itself usually works fine
with 250 and more is usually only needed for extensios with
deeply nested partials in fluid for example, the check is now
split to two error levels: Below 250 throws error level warning,
below 400 throws only a warning level warning.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Nicole Hummel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Nicole Hummel +1

Issues 2

Files 1

Review log 33

Show 8 earlier messages
  1. Nicole Hummel uploaded patch set 1 09/11/14, 07:40

  2. Markus Klein commented on patch set 1 CR +1 V +1 09/11/14, 15:20

    A new installation of mine recently crashed due to a too low nesting level. So one could really see that as error, since a wrong setting has fatal consequences, but I agree a warning should suffice. Maybe we can lower the value as well?
  3. Nicole Hummel commented on patch set 1 09/11/14, 15:30

    I would recommend to stay with that, as otherwise maybe the extension manager would fatal.
  4. Markus Klein commented on patch set 1 09/11/14, 15:32

    Good point. Thx.
  5. Christian Kuhn commented on patch set 1 V -1 09/13/14, 16:11

    imho, error *is* fine: If xdebug is installed and if the nesting level is too low, then parts of the core *will* crash with a fatal! This is a hard error and thus error level warning is fine. If xdebug is not present (eg. on production systems), no error is raised in the first place.
  6. Markus Klein commented on patch set 1 09/13/14, 16:45

    @Christian: I disagree here. *error* means that TYPO3 is not able to work at all. This is not the case here, it might only stop working in certain cases, like EM. Hence a *warning* is sufficient. The Core warns the dev that this setting might block TYPO3 CMS to provide the "best possible experience". ;-)
  7. Christian Kuhn commented on patch set 1 09/13/14, 17:00

    Nope. Fluid for example easily triggers the nesting level. We have several extbase / fluid based extensions that provide critical core functionality. If xdebug is installed, raising nesting level to a higher level is *must have*. The error level severity is very well justified! Those check should go red if the system environment is configured in a way that the system crashes in its standard use cases. And this is absolutely the case here.
  8. Nicole Hummel commented on patch set 1 09/13/14, 18:17

    @Chrsitian: I'm running TYPO3 CMS Core with xdebug.max_nesting_level = 250 since forever and hadn't any problem yet. So we should either reduce the needed value or the error level!
  1. Nicole Hummel commented on patch set 1 09/13/14, 18:18

    BTW: Running it with xdebug.max_nesting_level = 250 on Windows and Unix
  2. Anja Leichsenring commented on patch set 1 09/13/14, 19:34

    the limit was once raised by #59391. I had never problems with 250, too, and I remember discussions back then, why the raise should be neccessary. In case we keep the 400 as max. value, the decrase of LogLevel to warning might be fine. Just my 2 cents.
  3. Anja Leichsenring uploaded patch set 2 09/13/14, 20:32

  4. Anja Leichsenring commented on patch set 2 09/13/14, 20:33

    I introduced a hirarchy of LogLevel, smaller than 250 raises an error, smaller than 400 a warning. Can we all life with that?
  5. Markus Klein commented on patch set 2 09/13/14, 23:53

    Fine with me
  6. Markus Klein commented on patch set 2 09/13/14, 23:54

    Check.php:523

    must be >=
  7. Anja Leichsenring uploaded patch set 3 09/14/14, 09:10

  8. Markus Klein commented on patch set 3 CR -1 09/14/14, 12:09

    Check.php:523

    It was too late last night, so I overlooked that the first part is completely superfluous as it is implied by the first if condition. ;-) Will push an update
  9. Markus Klein uploaded patch set 4 09/14/14, 12:17

  10. Markus Klein voted on patch set 4 CR +1 V +1 09/14/14, 12:18

  11. Nicole Hummel voted on patch set 4 CR +1 V +1 09/15/14, 06:59

  12. Christian Kuhn commented on patch set 4 CR -1 09/15/14, 11:44

    Check.php:17

    obsolete
  13. Christian Kuhn commented on patch set 4 09/15/14, 11:47

    I think the text needs some rewording: 250 is absolute minimun, so this is the "critical" thing. "too low" is for < 400 and is then not an error anymore. Other than that, I'm now also fine with the patch, the split between warning and error is ok for me ...

    Check.php:530

    remove "either"
  14. Christian Kuhn commented on patch set 4 09/15/14, 11:47

    I'll rephrase a bit and will re-push.
  15. Markus Klein commented on patch set 4 CR -1 V 0 09/15/14, 12:00

    Agree to Christian's points.
  16. Christian Kuhn uploaded patch set 5 09/15/14, 12:00

  17. Christian Kuhn voted on patch set 5 CR +1 V +1 09/15/14, 12:02

  18. Nicole Hummel voted on patch set 5 CR +1 V +1 09/15/14, 12:12

  19. Wouter Wolters commented on patch set 5 V +1 CR +1 09/15/14, 12:13

    Markus please merge:-)
  20. Christian Kuhn commented on patch set 5 09/15/14, 12:20

    maybe let anja revote, she would be angry if the patch makes it after her work on it ;)
  21. Markus Klein commented on patch set 5 09/15/14, 12:37

    @Christian: Don't get the point? If it's about statistics, take a look at http://metrics.andygrunwald.com/statistics/gerrit/activity-monitor/analysis/59/ which also includes intermediate patch sets AFAIK.
  22. Markus Klein voted on patch set 5 CR +1 V +1 09/15/14, 12:38

  23. Anja Leichsenring commented on patch set 5 CR +2 V +2 09/15/14, 13:23

    Hi, thanks for the final touch. I am happy we found an agreement on the matter. Thanks, too, for waiting ;)
  24. Anja Leichsenring merged patch set 5 09/15/14, 13:23

  25. Anja Leichsenring commented on patch set 6 09/15/14, 13:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 7b89f276584e8fb9edf0b735de615b2a89f7c555