Review main Abandoned

32777[BUGFIX] Check if referenced TS exists

mostwanted CR 0 V 0 Easy +18 −10 updated 10/23/14, 00:35

Commit message

Properly validate if the referenced TypoScript object actually
exists to avoid PHP errors.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 16

  1. mostwanted uploaded patch set 1 09/15/14, 10:09

  2. Markus Klein commented on patch set 1 09/15/14, 12:03

    ContentObjectRenderer.php:731

    I don't like this approach very much. Please add a proper check to the if condition to check return value of getVal()
  3. Christian Kuhn updated the commit message in patch set 2 09/15/14, 12:09

  4. Wouter Wolters updated the commit message in patch set 3 09/15/14, 12:10

  5. Markus Klein commented on patch set 3 CR -1 09/15/14, 12:43

    See comment in patch set 1
  6. mostwanted uploaded patch set 4 09/15/14, 14:16

  7. mostwanted commented on patch set 1 09/15/14, 14:19

    ContentObjectRenderer.php:731 Reply

    I check $conf in patch set 4 *before* the if statement. Please let me know if this is ok for you.
  8. Markus Klein commented on patch set 4 09/15/14, 14:22

    Roland, please always fetch the latest patch set from Gerrit before making any modifications. You just reverted the changes to the commit message done by Wouter.
  9. mostwanted commented on patch set 4 09/15/14, 14:27

    sorry, i will take care in the evening.
  10. Markus Klein uploaded patch set 5 09/15/14, 14:32

  11. Markus Klein uploaded patch set 6 09/15/14, 14:34

  12. Markus Klein voted on patch set 6 CR +1 V +1 09/15/14, 14:34

  13. Wouter Wolters commented on patch set 6 09/15/14, 14:37

    ContentObjectRenderer.php:728

    Can we maybe rename this not understandable variable name?
  14. Markus Klein uploaded patch set 7 09/15/14, 14:40

  15. Wouter Wolters commented on patch set 7 CR +1 09/15/14, 14:53

    Thanks Markus. Hope to give this a test this evening
  16. Markus Klein abandoned the change 10/23/14, 00:35