32778[TASK] Use FLUIDTEMPLATE for rendering module Configuration
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Tymoteusz Motylewski +1
-
Verified V +2
- Markus Klein +2
- Tymoteusz Motylewski +1
Issues 1
Files 3
Review log 28
Show 3 earlier messages
-
Frank Nägler uploaded patch set 1 09/15/14, 12:21
-
Frank Nägler uploaded patch set 2 09/15/14, 12:24
-
Wouter Wolters commented on patch set 2 09/15/14, 21:00
ConfigurationView.php:35I'd rather call this $view. In normal extbase extension this is also called $this->viewConfigurationView.php:44no need to inject here, just use: /** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */ $flashMessageService = GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Messaging\\FlashMessageService');ConfigurationView.php:151GeneralUtility::getFileAbsFileName('EXT:lowlevel/Resources/Private/Templates/Backend/Configuration.html'ConfigurationView.php:284Boolean values need to be uppercase, so this is valid: TRUE, FALSE or NULLConfigurationView.php:345create an instance here for the flashMessageService.Configuration.html:13use tabs instead of spaces in this fileindex.php:24IMO this is wrong and no injection is needed. Explained in other file
-
Frank Nägler commented on patch set 2 09/15/14, 21:22
thx for your review, I will send a new patchset later or tomorrow.index.php:24Replythis change was necessary, else the @inject would not work. but if I remove the @inject then I can revert this change. -
Felix Kopp commented on patch set 2 V -1 09/15/14, 21:50
One more thing: Seems like the Fun-Menu content labels are brokenConfigurationView.php:291Do we need DocumenTemplate anymore? I think it is a good step to render content by Fluid into DocumentTemplate but the second step should be planned already: Deliver Layout/default.html and render docHeaderButtons as Backend menu ViewHelper. A FuncMenu ViewHelper would be great also since that is needed in many places. -
Felix Kopp commented on patch set 2 09/15/14, 21:51
Frank. Great work! We should use your approach as a best practice info for piBase - Fluid migration for other extensions also when it is complete! Thanks! -
Frank Nägler uploaded patch set 3 09/15/14, 22:22
-
Frank Nägler commented on patch set 3 09/15/14, 22:24
thx for all your feedback, here is a new patchset. I removed $GLOBALS['LANG']->getLL() and replaced it with LocalizationUtility::translate() one step more near to a new code structure. All hints and wishes from Wouter also included in the new patchset -
Felix Kopp commented on patch set 3 V +1 09/16/14, 22:35
Seems to work okay! Form remembers values. Off-topic: I get a strange error with TYPO3\CMS\Lowlevel\Utility\ArrayBrowser only with text value and RegExp option. That error exists with and without this patch.ConfigurationView.php:28view:) remove the var nameConfigurationView.php:285Note: This line brings the <form> tagConfiguration.html:25divider/spacer not needed any more - spaces should be created by t3skin itself -
Stefan Neufeind commented on patch set 3 09/16/14, 23:10
About using static calls for the translations: Didn't we want to avoid static calls for various reasons (testing, overloading/replacing, ...) where possible? But besides that many thanks for separating core and template here! -
Frank Nägler commented on patch set 3 09/17/14, 07:30
@Stefan: $GLOBALS['LANG']->getLL() is also ugly, but have you an idea how to get the labels without $GLOBALS['LANG']->getLL() or LocalizationUtility::translate() ? The idea is to bring the BE more and more in a new and modern direction. The best is to rewrite alle BE modules with extbase/fluid, but this is a really big task. I would like to see no translations in the controller, this should all be done with a view helper, but in this cleanup step it is not possible to do it. -
Markus Klein commented on patch set 3 09/17/14, 07:49
IMHO static calls are ok, but we shouldn't introduce new static methods. For testing, you could of course move these calls to a separate function, so it can be mocked in tests. -
Markus Klein updated the commit message in patch set 4 09/17/14, 08:42
-
Markus Klein commented on patch set 4 09/17/14, 08:47
ConfigurationView.php:267maybe keep the trim() for $lineConfigurationView.php:329api??ConfigurationView.php:331public? -
Markus Klein commented on patch set 4 09/17/14, 08:50
Configuration.html:3you can avoid these attributes if you initialize the standaloneview correctly. $view->getRequest()->setControllerExtensionName('lowlevel');Configuration.html:25why that? Just add the style to the div below -
Wouter Wolters commented on patch set 4 09/17/14, 08:56
ConfigurationView.php:28remove $template -
Frank Nägler uploaded patch set 5 09/17/14, 09:13
-
Frank Nägler commented on patch set 4 09/17/14, 09:13
ConfigurationView.php:28ReplyDoneConfigurationView.php:267ReplyDoneConfigurationView.php:329ReplyDoneConfigurationView.php:331ReplyDoneConfiguration.html:3ReplyDoneConfiguration.html:25Replywas a spacer in the old view, you are right, this can be moved into another div. -
Frank Nägler uploaded patch set 6 09/17/14, 09:52
-
Frank Nägler commented on patch set 6 09/17/14, 09:53
correct commit message -
Markus Klein updated the commit message in patch set 7 09/17/14, 10:07
-
Markus Klein commented on patch set 7 CR -1 09/17/14, 10:22
Configuration.html:29should only be shown if line has content -
Frank Nägler uploaded patch set 8 09/17/14, 17:38
-
Frank Nägler commented on patch set 8 09/17/14, 17:39
fixed the display of variable field and save button -
Markus Klein voted on patch set 8 CR +1 V +1 09/17/14, 18:39
-
Tymoteusz Motylewski voted on patch set 8 CR +1 V +1 09/20/14, 09:10
-
Markus Klein voted on patch set 8 CR +2 V +2 09/20/14, 21:27
-
Markus Klein merged patch set 8 09/20/14, 21:27
ConfigurationView.php:30