Review main Merged

32801[BUGFIX] Dummy WHERE condition compatibility

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 09/16/14, 13:18

Commit message

The Typo3DbBackend.php places a dummy where condition in case
$statementParts['where'] is empty. The condition is changed
for compatibility reasons with some DBMS.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Xavier Perseguers +1
  • Verified V +2
    • Markus Klein +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 10

  1. Andreas Kienast uploaded patch set 1 09/16/14, 12:14

  2. Andreas Kienast updated the commit message in patch set 2 09/16/14, 12:17

  3. Wouter Wolters voted on patch set 2 CR +1 09/16/14, 12:18

  4. Markus Klein updated the commit message in patch set 3 09/16/14, 12:46

  5. Markus Klein commented on patch set 3 CR +1 V +1 09/16/14, 12:46

    no-brainer
  6. Wouter Wolters voted on patch set 3 CR +1 09/16/14, 12:48

  7. Xavier Perseguers voted on patch set 3 CR +1 V +1 09/16/14, 13:01

  8. Markus Klein voted on patch set 3 CR +2 V +2 09/16/14, 13:17

  9. Markus Klein merged patch set 3 09/16/14, 13:18

  10. Markus Klein commented on patch set 4 09/16/14, 13:18

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 185ab5927697feb8733914089ddc120e3073903e