Review main Merged

32803[BUGFIX] Follow up: Remove PHP warnings when no icon is found

Nicole Hummel CR +2 V +2 Easy +3 −3 updated 09/16/14, 13:42

Commit message

With https://review.typo3.org/32616/ a check with file_exists() was
introduced to prevent warnings on accessing non-image files. The check
returns true for files and folders. Now warnings are thrown, if an image
icon links to a folder. This patch replaces file_exists() with is_file()
to prevent further warnings.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 10

  1. Nicole Hummel uploaded patch set 1 09/16/14, 13:02

  2. Markus Klein commented on patch set 1 V +1 CR +1 09/16/14, 13:04

    no-brainer
  3. Andreas Kienast voted on patch set 1 CR +1 V +1 09/16/14, 13:05

  4. Wouter Wolters commented on patch set 1 09/16/14, 13:17

    non-image
  5. Markus Klein updated the commit message in patch set 2 09/16/14, 13:32

  6. Markus Klein commented on patch set 2 V +1 CR +1 09/16/14, 13:32

    fixed the commit msg
  7. Andreas Kienast voted on patch set 2 CR +1 V +1 09/16/14, 13:35

  8. Wouter Wolters voted on patch set 2 V +2 CR +2 09/16/14, 13:41

  9. Wouter Wolters merged patch set 2 09/16/14, 13:41

  10. Wouter Wolters commented on patch set 3 09/16/14, 13:42

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit cf021336fbd6ef9547e25fb3cfce1e6af8734dbc