Review main Merged

32816[FEATURE] Video player in backend (i) window

Felix Kopp CR +2 V +2 Normal +50 −14 updated 10/28/14, 21:01

Commit message

Allow video and audio playback in the backend (i) element
information window.

Uses the new introduced RenderingRegistry to find a matching
rendering class (#61800).

Brings default letter box background color for <Video> tags.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 29

Show 4 earlier messages
  1. Felix Kopp uploaded patch set 1 09/16/14, 23:23

  2. Felix Kopp commented on patch set 1 09/16/14, 23:25

    ElementInformationController.php:275

    No options here. Should we base the switch on file extension or mimType? Do we need a support check in the browser view: I say no since only IE9+ are supported now.
  3. Felix Kopp commented on patch set 1 09/16/14, 23:28

    Do we want black bg color for smaller videos?
  4. Helmut Hummel commented on patch set 1 09/17/14, 08:12

    ElementInformationController.php:257

    please use ->getMimeType() instead!
  1. Frans Saris commented on patch set 1 09/17/14, 09:25

    ElementInformationController.php:275 Reply

    Imo this switch is to static. We should create a registry of somekind you can feed with a file and as a return it gives you the preview html. I started something already for fronted use, maybe we can enhance this so it also useable in BE. See https://github.com/fsaris/fal_online_media_connector Currently it only supports YouTube and Vimeo but my intention is to also add local video file support. And maybe also audio files etc.
  2. Felix Kopp commented on patch set 1 09/17/14, 12:19

    Hi Frans, can you release the FAL-File to HTML-converter factory within the near future? Otherwise I suggest we merge this change and bring the 100% solution at a later stage. What do you think?
  3. Frans Saris commented on patch set 1 09/19/14, 11:50

    Near future as in before the end of this year, sure. But not in the next weeks. I'm not sure about merging this right now as it really restricted in its possibilities. But if it helps you to get something done then go ahead :)
  4. Frans Saris commented on patch set 1 09/19/14, 19:57

    I give it some more thought and I think I can provide something within the next week.
  5. Frans Saris uploaded patch set 2 09/27/14, 20:02

  6. Frans Saris commented on patch set 2 09/27/14, 20:04

  7. Frans Saris uploaded patch set 3 10/19/14, 18:35

  8. Frans Saris uploaded patch set 4 10/20/14, 18:19

  9. Markus Klein commented on patch set 4 10/20/14, 20:26

    ElementInformationController.php:273

    Actually this part should go into a renderer as well. ImageRenderer
  10. Felix Kopp commented on patch set 4 10/24/14, 18:16

    I love the renderers!!
  11. Frans Saris commented on patch set 4 10/24/14, 19:12

    ElementInformationController.php:273 Reply

    Will give this a look after next week
  12. Felix Kopp uploaded patch set 5 10/26/14, 10:25

  13. Felix Kopp commented on patch set 5 CR +1 V +1 10/26/14, 10:26

    I started the patch - was changed a lot by Frans and the team. Therefor I vote here as well.
  14. Georg Ringer commented on patch set 5 CR -1 V -1 10/26/14, 18:44

    Awesome!
  15. Georg Ringer voted on patch set 5 CR +1 V +1 10/26/14, 18:59

  16. Wouter Wolters commented on patch set 5 10/26/14, 22:14

    IMO this can have a rst file describing this new possibility
    introduced
  17. Christian Kuhn commented on patch set 5 CR -1 10/27/14, 13:49

    cool thing! tested with an .ogg video and works like a charm :) Just should get a .rst file for the feature documenation, will take care of that.
  18. Christian Kuhn uploaded patch set 6 10/27/14, 14:01

  19. Christian Kuhn voted on patch set 6 CR +1 V +1 10/27/14, 14:01

  20. Georg Ringer voted on patch set 6 CR +2 V +2 10/27/14, 14:05

  21. Wouter Wolters updated the commit message in patch set 7 10/27/14, 14:05

  22. Wouter Wolters voted on patch set 7 V +1 CR +1 10/27/14, 14:05

  23. Georg Ringer voted on patch set 7 CR +2 V +2 10/27/14, 14:06

  24. Georg Ringer merged patch set 7 10/27/14, 14:06

  25. Felix Kopp commented on patch set 8 10/28/14, 21:01

    Nice! Thank you for the merge