32817[BUGFIX] Do not check file extension on local file
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Frans Saris +1
- Helmut Hummel +1
-
Verified V +2
- Stefan Neufeind +2
- Frans Saris +1
Issues 1
Files 1
Review log 12
-
Alexander Opitz uploaded patch set 1 09/17/14, 08:08
-
Alexander Opitz commented on patch set 1 09/17/14, 08:11
In Question: - Do we need a "breaking docu"? As the function is more or less internal. For Backporting to 6.2: - It's planned that the 6.2 backport only removes the usage of the $localFilePath in the if statement of assureFileAddPermissions -
Helmut Hummel commented on patch set 1 CR +1 09/17/14, 08:18
ResourceStorage.php:1081this change here is crutial to not introduce a vulnerability! Maybe add a comment that the check needs to be *after* the calculation of the targetFileName -
Frans Saris voted on patch set 1 CR +1 09/17/14, 16:29
-
Frans Saris voted on patch set 1 V +1 09/19/14, 15:40
-
Stefan Neufeind voted on patch set 1 CR +1 09/20/14, 22:24
-
Frans Saris commented on patch set 1 09/21/14, 08:11
Stefan could you maybe also verify this patch? - Add following to your localconf $TYPO3_CONF_VARS['BE']['fileExtensions']['webspace']['allow'] = 'png,gif,jpg,jpeg,pdf'; $TYPO3_CONF_VARS['BE']['fileExtensions']['webspace']['deny'] = '*'; - Login as non admin user - Try to upload a file. -
Stefan Neufeind voted on patch set 1 CR +2 V +2 09/21/14, 16:47
-
Stefan Neufeind merged patch set 1 09/21/14, 16:47
-
Stefan Neufeind commented on patch set 2 09/21/14, 16:47
@Alex: How did you plan to backport this? Please go ahead :-) -
Alexander Opitz commented on patch set 2 09/23/14, 09:15
Backport: https://review.typo3.org/#/c/32929/ -
Oliver Hader commented on patch set 2 09/23/14, 11:16
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 692a8000cebf8a510cbc5621a7a1bfeb06e1b002