Review main Merged

32820[FEATURE] Migrate open-docs counter to .badge

Felix Kopp CR +2 V +2 Easy +9 −20 updated 09/18/14, 10:17

Commit message

During streamline of the backend we make use of the Bootstrap .badge
component. The Badge can be attached to every toolbar / menu item to
show a notification / counter.

An input field is the wrong component: no input is possible.
Also CSS can be removed for the former inline input.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 5

Review log 16

  1. Felix Kopp uploaded patch set 1 09/17/14, 10:23

  2. Wouter Wolters updated the commit message in patch set 2 09/17/14, 10:26

  3. Wouter Wolters voted on patch set 2 V +1 CR +1 09/17/14, 10:28

  4. Frank Nägler uploaded patch set 3 09/18/14, 07:51

  5. Frank Nägler commented on patch set 3 09/18/14, 07:52

    A badge should only be visible if it has a meaning. A badge with a value of 0 creates unnecessary attention. For this reason, I have adapted the script slightly. The badge is now visible only if the number of open docs is greater then 0
  6. Felix Kopp commented on patch set 3 09/18/14, 08:32

    Better!
  7. Markus Klein commented on patch set 3 CR -1 09/18/14, 08:57

    opendocs.js:100

    what about counter.toggle(num > 0)? this way more readable than this ugly construction
  8. Wouter Wolters commented on patch set 3 09/18/14, 09:05

    opendocs.js:100 Reply

    +1 for better readability here
  9. Frank Nägler uploaded patch set 4 09/18/14, 09:06

  10. Frank Nägler commented on patch set 4 09/18/14, 09:07

    change the JS if/else construct to the toggle method, thx for the hint.
  11. Frank Nägler commented on patch set 3 09/18/14, 09:07

    thx for the hint, good idea

    opendocs.js:100 Reply

    Done
  12. Markus Klein commented on patch set 4 CR +1 V +1 09/18/14, 09:17

    If you hove the icon there's a underline appearing, that looks a bit strange
  13. Wouter Wolters commented on patch set 4 V +1 CR +1 09/18/14, 09:41

    Felix, wanna fix the underline now or in a separate patch?
  14. Felix Kopp commented on patch set 4 09/18/14, 10:04

    Underline must be fixed in a central place - now an issue of this patch. The ToolbarItems need a new central markup in HTML and according CSSes. Fixed later.
  15. Markus Klein commented on patch set 4 CR +2 V +2 09/18/14, 10:17

    alright
  16. Markus Klein merged patch set 4 09/18/14, 10:17