32820[FEATURE] Migrate open-docs counter to .badge
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
Issues 1
Files 5
- typo3/sysext/opendocs/Classes/Controller/OpendocsController.php+3 −2
- typo3/sysext/opendocs/Resources/Public/Css/opendocs.css+0 −14
- typo3/sysext/opendocs/Resources/Public/JavaScript/opendocs.js3+4 −2
- typo3/sysext/t3skin/Resources/Private/Styles/bootstrap/variables.less+1 −1
- typo3/sysext/t3skin/Resources/Public/Css/visual/t3kin.css+1 −1
Review log 16
-
Felix Kopp uploaded patch set 1 09/17/14, 10:23
-
Wouter Wolters updated the commit message in patch set 2 09/17/14, 10:26
-
Wouter Wolters voted on patch set 2 V +1 CR +1 09/17/14, 10:28
-
Frank Nägler uploaded patch set 3 09/18/14, 07:51
-
Frank Nägler commented on patch set 3 09/18/14, 07:52
A badge should only be visible if it has a meaning. A badge with a value of 0 creates unnecessary attention. For this reason, I have adapted the script slightly. The badge is now visible only if the number of open docs is greater then 0 -
Felix Kopp commented on patch set 3 09/18/14, 08:32
Better! -
Markus Klein commented on patch set 3 CR -1 09/18/14, 08:57
opendocs.js:100what about counter.toggle(num > 0)? this way more readable than this ugly construction -
Wouter Wolters commented on patch set 3 09/18/14, 09:05
opendocs.js:100Reply+1 for better readability here -
Frank Nägler uploaded patch set 4 09/18/14, 09:06
-
Frank Nägler commented on patch set 4 09/18/14, 09:07
change the JS if/else construct to the toggle method, thx for the hint. -
Frank Nägler commented on patch set 3 09/18/14, 09:07
thx for the hint, good ideaopendocs.js:100ReplyDone -
Markus Klein commented on patch set 4 CR +1 V +1 09/18/14, 09:17
If you hove the icon there's a underline appearing, that looks a bit strange -
Wouter Wolters commented on patch set 4 V +1 CR +1 09/18/14, 09:41
Felix, wanna fix the underline now or in a separate patch? -
Felix Kopp commented on patch set 4 09/18/14, 10:04
Underline must be fixed in a central place - now an issue of this patch. The ToolbarItems need a new central markup in HTML and according CSSes. Fixed later. -
Markus Klein commented on patch set 4 CR +2 V +2 09/18/14, 10:17
alright -
Markus Klein merged patch set 4 09/18/14, 10:17