Review main Merged

32873[BUGFIX] Invalid closure in AbstractMenuContentObject

Francois Suter CR +2 V +2 Easy +8 −3 updated 11/13/14, 14:07

Commit message

Issue #58792 introduced a closure in AbstractMenuContentObject.php
which is not PHP 5.3 compatible. Since TYPO3 6.2 must still
support PHP 5.3, and master should be for now.
The closure is replaced by a simple loop.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Helmut Hummel +2
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1

Issues 1

Files 1

Review log 9

  1. Francois Suter uploaded patch set 1 09/18/14, 20:24

  2. Francois Suter abandoned the change 09/18/14, 20:25

    Sorry, wrong branch.
  3. Helmut Hummel restored the change 09/19/14, 08:50

    should also go in master
  4. Helmut Hummel uploaded patch set 2 09/19/14, 08:50

  5. Helmut Hummel voted on patch set 2 CR +2 09/19/14, 08:51

  6. Markus Klein voted on patch set 2 CR +1 V +1 09/19/14, 08:58

  7. Anja Leichsenring voted on patch set 2 CR +2 V +2 09/19/14, 09:51

  8. Anja Leichsenring merged patch set 2 09/19/14, 09:51

  9. Markus Klein commented on patch set 3 11/13/14, 14:07

    AbstractMenuContentObject.php:921