Review TYPO3_6-2 Merged

32874[BUGFIX] Invalid closure in AbstractMenuContentObject

Francois Suter CR +2 V +2 Easy +8 −3 updated 09/19/14, 09:51

Commit message

Issue #58792 introduced a closure in AbstractMenuContentObject.php
which is not PHP 5.3 compatible. Since TYPO3 6.2 must still
support PHP 5.3, and master should be for now.
The closure is replaced by a simple loop.

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2

Issues 1

Files 1

Review log 12

  1. Francois Suter uploaded patch set 1 09/18/14, 20:26

  2. Francois Suter commented on patch set 1 09/18/14, 20:27

    Not tested, though. I had not setup ready for it. At least it removed the PHP fatal error with PHP 5.3.
  3. Wouter Wolters commented on patch set 1 09/18/14, 20:35

    To my knowledge we did not drop support for PHP 5.3 in current master. So this should also go in to master branch.. will ask some people now
  4. Markus Klein commented on patch set 1 CR +1 V +1 09/18/14, 20:43

    Nope, master is PHP 5.5.
  5. Markus Klein updated the commit message in patch set 2 09/19/14, 01:41

  6. Markus Klein voted on patch set 2 CR +1 V +1 09/19/14, 01:41

  7. Stefan Neufeind voted on patch set 2 CR +1 09/19/14, 07:26

  8. Helmut Hummel updated the commit message in patch set 3 09/19/14, 08:48

  9. Markus Klein voted on patch set 3 CR +1 V +1 09/19/14, 08:58

  10. Anja Leichsenring uploaded patch set 4 09/19/14, 09:51

  11. Anja Leichsenring voted on patch set 4 CR +2 V +2 09/19/14, 09:51

  12. Anja Leichsenring merged patch set 4 09/19/14, 09:51