Review main Merged

32883[BUGFIX] ADOdb: Set charset properly

Andreas Kienast CR +2 V +2 Easy +13 −8 updated 11/05/14, 00:30

Commit message

Using ADOdb, the charset might not be set properly, since every
database driver needs to define their own "SetCharSet" method. Every
driver extends from ADOConnection. "SetCharSet" of this class just
returns FALSE.

Review

  • Code review CR +2
    • Markus Klein +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 2

Review log 33

Show 8 earlier messages
  1. Andreas Kienast uploaded patch set 1 09/19/14, 11:56

  2. Markus Klein updated the commit message in patch set 2 09/19/14, 13:20

  3. Markus Klein commented on patch set 2 CR +1 09/19/14, 13:20

    maybe put a note in some file that you modified the third party code, otherwise I fear we forget about this change in 1 year.
  4. Andreas Kienast uploaded patch set 3 09/19/14, 13:26

  5. Markus Klein commented on patch set 3 09/20/14, 21:26

    adodb.inc.php:2719

    did you change the file encoding?
  6. Andreas Kienast commented on patch set 3 09/21/14, 13:14

    adodb.inc.php:2719 Reply

    Great. Netbeans warned me that the file is not UTF-8 encoded, but my Git client didn't show a difference here afterwards.
  7. Andreas Kienast uploaded patch set 4 09/22/14, 06:45

  8. Andreas Kienast commented on patch set 4 09/22/14, 06:46

    Fixed the encoding by hand.
  1. Markus Klein voted on patch set 4 CR +1 V +1 09/22/14, 09:03

  2. Oliver Hader commented on patch set 4 09/23/14, 11:23

    adodb.inc.php:2040

    This is the only change of the whole patch, right?
  3. Andreas Kienast commented on patch set 4 09/23/14, 11:29

    adodb.inc.php:2040 Reply

    That's right.
  4. Oliver Hader uploaded patch set 5 09/23/14, 11:29

  5. Oliver Hader uploaded patch set 6 09/23/14, 11:33

  6. Oliver Hader voted on patch set 6 CR +1 09/23/14, 11:35

  7. Markus Klein commented on patch set 6 CR -2 09/23/14, 12:00

    Nope Olly, the extra file is on purpose!
  8. Andreas Kienast commented on patch set 6 09/23/14, 12:03

    > Nope Olly, the extra file is on purpose! That's my mistake, sorry. I thought he meant the single line only as "complete patch". > Nope Olly, the extra file is on purpose!
  9. Oliver Hader uploaded patch set 7 09/23/14, 12:04

  10. Oliver Hader commented on patch set 5 09/23/14, 12:05

    Switched back to version 5 of the patch history... I don't care much, where that information is stored
  11. Oliver Hader voted on patch set 7 CR +1 09/23/14, 12:06

  12. Oliver Hader wrote 09/23/14, 12:07

    Removed the following approvals: * Code-Review-2 by Markus Klein <klein.t3@reelworx.at>
  13. Markus Klein voted on patch set 7 CR +1 V +1 09/23/14, 12:34

  14. Tymoteusz Motylewski commented on patch set 7 CR -1 09/26/14, 20:26

    What problem/usecase are we trying to solve with it? I find the comments in github quite valid see https://github.com/ADOdb/ADOdb/pull/39 Also this patch changes the method signatured, as it is expected that this method returns a boolean.
  15. Markus Klein commented on patch set 7 CR 0 V 0 09/26/14, 21:26

    Taking back my votes here.
  16. Andreas Kienast commented on patch set 7 09/27/14, 09:49

    > What problem/usecase are we trying to solve with it? > I find the comments in github quite valid see https://github.com/ADOdb/ADOdb/pull/39 > > Also this patch changes the method signatured, as it is expected > that this method returns a boolean. The problem is: The drivers for the "default" DBMS have their own SetCharSet methods that actually do anything, the Oracle driver hasn't implemented that. This breaks umlauts since the charset of the connection is FALSE by default. The TYPO3 DBAL implementation iterates thru EXTCONF/dbal/config/driverOptions and sets the properties of the used ADOConnection, please see typo3/sysext/dbal/Classes/Database/DatabaseConnection.php, line 3039. In ADOdb, the return value of SetCharSet is not even used anywhere[1]. [1] http://pastebin.com/7n4vGCja
  17. Tymoteusz Motylewski commented on patch set 7 CR 0 09/28/14, 18:01

    removing -1 after getting more context. @Andreas, can you please comment the resoning on github?
  18. Andreas Kienast commented on patch set 7 09/29/14, 07:12

    > removing -1 after getting more context. @Andreas, can you please > comment the resoning on github? FYI: https://github.com/ADOdb/ADOdb/pull/39#issuecomment-57120924
  19. Markus Klein commented on patch set 7 09/29/14, 07:32

    adodb.inc.php:2040

    return true
  20. Andreas Kienast uploaded patch set 8 09/29/14, 07:44

  21. Tymoteusz Motylewski voted on patch set 8 CR +1 09/29/14, 11:19

  22. Markus Klein voted on patch set 8 CR +1 V +1 10/30/14, 19:21

  23. Markus Klein voted on patch set 8 CR +2 V +2 11/05/14, 00:29

  24. Markus Klein merged patch set 8 11/05/14, 00:29

  25. Markus Klein commented on patch set 9 11/05/14, 00:30

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit a7c98ad56714d504e27ec8e832cd7a161dd0fcaf