3289[FEATURE] Hide translated records from List module
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
-
Verified V +2
- Steffen Gebert +2
Issues 1
Files 2
Review log 46
Show 21 earlier messages
-
Stefan Geith uploaded patch set 2 07/31/11, 18:39
-
Stefan Geith uploaded patch set 3 07/31/11, 18:39
-
Stefan Geith uploaded patch set 4 07/31/11, 18:39
-
Dmitry Dulepov commented on patch set 3 07/31/11, 18:39
Fails; I would prefer that you didn't submit this Using undefined variable $hideTranslation in typo3/class.db_list.inc: causes warnings. Please, make sure you always initialize variables. Using undefined variable $TCA (must be $GLOBALS['TCA']): the patch does not work with master branch at all. -
Georg Ringer commented on patch set 4 2 comments 07/31/11, 18:39
I would prefer that you didn't submit this -
Stefan Geith uploaded patch set 6 07/31/11, 18:39
-
Stefan Geith uploaded patch set 7 07/31/11, 18:39
-
Stefan Geith uploaded patch set 8 07/31/11, 18:39
-
Steffen Gebert commented on patch set 5 3 comments 07/31/11, 18:39
I would prefer that you didn't submit this -
Steffen Gebert uploaded patch set 5 07/31/11, 18:39
-
Steffen Gebert commented on patch set 6 07/31/11, 18:39
I would prefer that you didn't submit this Please have a look at Patch Set 5 first -
Philipp Gampe commented on patch set 8 1 comment 07/31/11, 18:39
Fails Please write a setter for hidetranslations -
Philipp Gampe commented on patch set 8 07/31/11, 18:39
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 8 07/31/11, 18:39
I changed the protected to public and it works :) -
Stefan Geith uploaded patch set 10 07/31/11, 18:39
-
Stefan Geith commented on patch set 11 07/31/11, 18:39
... But I'm fine with inList also, because I only use hideTranslations=* ... -
Stefan Geith uploaded patch set 11 07/31/11, 18:39
-
Stefan Geith commented on patch set 11 07/31/11, 18:39
I think it should work the same way as hideTabels. And the Opion hideTabels works with trimExplode. -
Steffen Gebert uploaded patch set 12 07/31/11, 18:39
-
Steffen Gebert commented on patch set 12 V 0 07/31/11, 18:39
by team member; Looks good to me, approved Just optimized the commit message. Adding pending documentation. -
Philipp Gampe uploaded patch set 9 07/31/11, 18:39
-
Philipp Gampe commented on patch set 9 07/31/11, 18:39
Verified; Looks good to me, but someone else must approve Ok, I just changed it to public and pushed the change. Works for me now. -
Philipp Gampe commented on patch set 10 07/31/11, 18:39
Fails -
Philipp Gampe commented on patch set 10 07/31/11, 18:39
This is not the same as patch set 9. This fails now if you have spaces between your tables: # this works mod.web_list.hideTranslations = list,of,tables #this worked with old patchset too, but does not now mod.web_list.hideTranslations = list, of, tables -
Philipp Gampe commented on patch set 11 07/31/11, 18:39
Verified; Looks good to me, but someone else must approve Now I like it. -
Georg Schönweger commented on patch set 4 07/31/11, 18:39
Looks good to me, but someone else must approve -
Arvid Jakobsson commented on patch set 1 07/31/11, 18:39
I would prefer that you didn't submit this hideTranslation / hideTranslations is used inconsistently. I prefer hideTranslations though.class.db_list.inc:121Tables misspelled. Tabels -> Tables. $hideTranslations used in other places, should be hideTranslations here as well (with s!)class.db_list.inc:476$this->hideTranslation without S is used here as well.index.php:240hideTranslation or hideTranslations? -
Arvid Jakobsson commented on patch set 2 07/31/11, 18:39
Looks good to me, but someone else must approve -
Arvid Jakobsson commented on patch set 3 07/31/11, 18:39
Looks good to me, but someone else must approve -
Jo Hasenau commented on patch set 9 07/31/11, 18:39
I would prefer that you didn't submit this We should use t3lib_div::inList instead of doing in_array after t3lib_div::trimExplode -
Jo Hasenau commented on patch set 10 07/31/11, 18:39
Verified; Looks good to me, but someone else must approve -
Jo Hasenau commented on patch set 11 07/31/11, 18:39
Verified; Looks good to me, but someone else must approve -
Jo Hasenau commented on patch set 11 07/31/11, 18:39
Verified; I would prefer that you didn't submit this It works now with spaces, but IMHO it would be better to just not allow spaces to be entered in the list of tables instead of using array functions just to make them possible. -
Mr. Jenkins commented on patch set 1 07/31/11, 18:39
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/1140/ : FAILURE -
Mr. Jenkins commented on patch set 2 07/31/11, 18:39
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/1150/ : FAILURE -
Mr. Jenkins commented on patch set 3 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1151/ : SUCCESS -
Mr. Jenkins commented on patch set 4 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1158/ : SUCCESS -
Mr. Jenkins commented on patch set 5 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1425/ : SUCCESS -
Mr. Jenkins commented on patch set 6 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1427/ : SUCCESS -
Mr. Jenkins commented on patch set 7 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1429/ : SUCCESS -
Mr. Jenkins commented on patch set 8 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1431/ : SUCCESS -
Mr. Jenkins commented on patch set 9 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1435/ : SUCCESS -
Mr. Jenkins commented on patch set 10 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1457/ : SUCCESS -
Mr. Jenkins commented on patch set 11 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1458/ : SUCCESS -
Mr. Jenkins commented on patch set 12 07/31/11, 18:39
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1475/ : SUCCESS -
Steffen Gebert merged patch set 12 07/31/11, 18:39