Review main Abandoned

32902[TASK] Cleanup backend CSS classes and markup

Ingo Pfennigstorf CR 0 V 0 Normal +88 −155 updated 12/03/14, 06:45

Commit message

This patch removes not needed CSS classes such as bgColor4 and so on.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 31

Show 11 more files

Review log 9

  1. Ingo Pfennigstorf uploaded patch set 1 09/21/14, 17:56

  2. Ingo Pfennigstorf commented on patch set 1 09/21/14, 17:58

    Status _may_ be WIP. Currently mainly removes table classes that would look ugly™ in the current bootstrap based backend
  3. Frans Saris commented on patch set 1 09/21/14, 19:15

    What about bgColor5?
  4. Ingo Pfennigstorf commented on patch set 1 09/21/14, 19:16

    expand to bgColor[0-9] ;)
  5. Markus Klein commented on patch set 1 CR -1 09/21/14, 21:10

    class.browse_links.php:62

    it is still used for alternating row design here.

    DocumentTemplate.php:361

    what about the others?
  6. Felix Kopp commented on patch set 1 09/21/14, 22:30

    PHATT!!!!! Hope, that I will find time during the week to review. Anyways don't wait for me :)
  7. Felix Kopp commented on patch set 1 10/20/14, 22:13

    What can be merged and which parts have been merged already in different patches?

    class.browse_links.php:62 Reply

    Do remove the bgColorClass variable also. Follow up might add <table class="t3-table"> ... BUT I don't think that trees should be based on table tags at all (different topic, different patch)
  8. Felix Kopp commented on patch set 1 10/31/14, 21:50

    Ingo, on it still?
  9. Ingo Pfennigstorf abandoned the change 12/03/14, 06:45