Review main Merged

32904[TASK] Change input type for backend search result limit to "number"

Ingo Pfennigstorf CR +2 V +2 Easy +1 −1 updated 09/24/14, 12:26

Commit message

This changes the html input type for the backend search result limit
from "text" to the html5 attribute "number".

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Froemken +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Froemken +1

Issues 1

Files 1

Review log 10

  1. Ingo Pfennigstorf uploaded patch set 1 09/21/14, 18:26

  2. Frans Saris voted on patch set 1 CR +1 09/21/14, 19:19

  3. Stefan Froemken commented on patch set 1 CR +1 V +1 09/22/14, 06:48

    It works, but now you can see only 3 instead of 4 numbers. Maybe we should increase the width of this field, too.
  4. Ingo Pfennigstorf commented on patch set 1 09/22/14, 07:00

    @Stefan is this a valid use case limiting the results to >= 1000? If yes I will push a new patchset
  5. Stefan Froemken commented on patch set 1 09/22/14, 07:08

    I don't want to limit anything. After applying your patch a little icon appears in the textfield to de/increase the numbers +/- 1. This little browser widget costs the space of one number. So, before applying the patch I can see f.e. 1000. After the patch I only see "000", because the field is to small. In my opinion we should add 10 or 15 pixel again, to see 4 numbers as before the patch.
  6. Ingo Pfennigstorf uploaded patch set 2 09/22/14, 21:39

  7. Stefan Froemken commented on patch set 2 CR +1 V +1 09/23/14, 20:20

    Yeah...that looks much better. Thank you.
  8. Stefan Neufeind commented on patch set 2 09/24/14, 01:45

    There are some other number-fields in used. For example the maximum number of Records in ImportExportController or a page-number to jump to in DatabaseRecordList. Add those to this patch as well?
  9. Christian Kuhn commented on patch set 2 CR +2 V +2 09/24/14, 12:26

    The other matches in the backend could be handled with other patches, this one is already nice and works well.
  10. Christian Kuhn merged patch set 2 09/24/14, 12:26