Review main Merged Breaking

32910[!!!][TASK] Remove deprecated TCA functions

Wouter Wolters CR +2 V +2 Normal +54 −56 updated 09/23/14, 16:33

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 4

Review log 11

  1. Wouter Wolters uploaded patch set 1 09/21/14, 20:57

  2. Markus Klein commented on patch set 1 CR -1 09/21/14, 23:34

    rst Documentation missing
  3. Wouter Wolters uploaded patch set 2 09/22/14, 19:39

  4. Markus Klein commented on patch set 2 09/23/14, 09:42

    Breaking-61785-FrontendTcaFunctionsRemoved.rst:3

    I think the line needs to be of same length

    Breaking-61785-FrontendTcaFunctionsRemoved.rst:26

    eID

    Breaking-61785-LoadTcaFunctionRemoved.rst:25

    contexts
  5. Wouter Wolters commented on patch set 2 09/23/14, 09:48

    Breaking-61785-FrontendTcaFunctionsRemoved.rst:3 Reply

    I don't know what to do here. I just copied this from another rst file and edited it.

    Breaking-61785-FrontendTcaFunctionsRemoved.rst:26 Reply

    This text is copied from the TYPO3 source;-) So if this needs to be changed then change it also in the core

    Breaking-61785-LoadTcaFunctionRemoved.rst:25 Reply

    Same here, just copied from the TYPO3 source.
  6. Markus Klein updated the commit message in patch set 3 09/23/14, 10:28

  7. Markus Klein voted on patch set 3 CR +1 V +1 09/23/14, 10:28

  8. Christian Kuhn uploaded patch set 4 09/23/14, 15:44

  9. Christian Kuhn commented on patch set 4 CR +1 V +1 09/23/14, 15:45

    Minor .rst file rephrasings.
  10. Markus Klein voted on patch set 4 CR +2 V +2 09/23/14, 16:33

  11. Markus Klein merged patch set 4 09/23/14, 16:33