32913[TASK] Use fully qualified name resolution in PHP 5.5
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Alexander Opitz +1
- Markus Klein +1
- Wouter Wolters +1
- Anja Leichsenring +1
-
Verified V +2
- Xavier Perseguers +2
- Alexander Opitz +1
- Markus Klein +1
- Wouter Wolters +1
- Anja Leichsenring +1
Issues 1
Files 490
- typo3/sysext/aboutmodules/Classes/Controller/ModulesController.php+1 −1
- typo3/sysext/backend/Classes/Configuration/TsConfigParser.php+2 −2
- typo3/sysext/backend/Classes/ContextMenu/Extdirect/AbstractExtdirectContextMenu.php+2 −2
- typo3/sysext/backend/Classes/ContextMenu/Pagetree/Extdirect/ContextMenuConfiguration.php+2 −2
- typo3/sysext/backend/Classes/ContextMenu/AbstractContextMenuDataProvider.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+3 −3
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+3 −3
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+3 −3
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/CreateFolderController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/FileController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/FileUploadController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/RenameFileController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php+3 −3
- typo3/sysext/backend/Classes/Controller/Wizard/ColorpickerController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/EditController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/FormsController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/RteController.php+3 −3
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+2 −2
Show 470 more files
- typo3/sysext/backend/Classes/Controller/BackendController.php+4 −4
- typo3/sysext/backend/Classes/Controller/BackendLayoutWizardController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ClickMenuController.php+5 −5
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+7 −7
- typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LoginController.php+2 −2
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+2 −2
- typo3/sysext/backend/Classes/Controller/NoDocumentsOpenController.php+3 −3
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+14 −14
- typo3/sysext/backend/Classes/Controller/PageTreeNavigationController.php+3 −3
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+2 −2
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/FlexElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InlineElement.php+8 −8
- typo3/sysext/backend/Classes/Form/Element/SelectElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TreeElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/ValueSlider.php+1 −1
- typo3/sysext/backend/Classes/Form/DataPreprocessor.php+7 −7
- typo3/sysext/backend/Classes/Form/FormDataTraverser.php+1 −1
- typo3/sysext/backend/Classes/Form/FormEngine.php+22 −22
- typo3/sysext/backend/Classes/Form/FrontendFormEngine.php+1 −1
- typo3/sysext/backend/Classes/History/RecordHistory.php+4 −4
- typo3/sysext/backend/Classes/Module/AbstractFunctionModule.php+1 −1
- typo3/sysext/backend/Classes/Module/BaseScriptClass.php+2 −2
- typo3/sysext/backend/Classes/Module/ModuleController.php+4 −4
- typo3/sysext/backend/Classes/Module/ModuleLoader.php+1 −1
- typo3/sysext/backend/Classes/Module/ModuleSettings.php+1 −1
- typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php+1 −1
- typo3/sysext/backend/Classes/Rte/AbstractRte.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/ExtDirect/LiveSearchDataProvider.php+2 −2
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+2 −2
- typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php+1 −1
- typo3/sysext/backend/Classes/Sprite/SpriteBuildingHandler.php+1 −1
- typo3/sysext/backend/Classes/Sprite/SpriteManager.php+2 −2
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+4 −4
- typo3/sysext/backend/Classes/Toolbar/LiveSearchToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Toolbar/ShortcutToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Tree/Pagetree/Commands.php+2 −2
- typo3/sysext/backend/Classes/Tree/Pagetree/DataProvider.php+6 −6
- typo3/sysext/backend/Classes/Tree/Pagetree/ExtdirectTreeCommands.php+16 −16
- typo3/sysext/backend/Classes/Tree/Pagetree/ExtdirectTreeDataProvider.php+4 −4
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+10 −10
- typo3/sysext/backend/Classes/Utility/IconUtility.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayout/Extdirect/ExtdirectPageCommands.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+3 −3
- typo3/sysext/backend/Classes/View/ModuleMenuView.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+2 −2
- typo3/sysext/backend/Modules/File/Edit/index.php+1 −1
- typo3/sysext/backend/Modules/File/Newfolder/index.php+1 −1
- typo3/sysext/backend/Modules/File/Rename/index.php+1 −1
- typo3/sysext/backend/Modules/File/Upload/index.php+1 −1
- typo3/sysext/backend/Modules/RecordHistory/index.php+1 −1
- typo3/sysext/backend/Modules/Wizards/AddWizard/index.php+1 −1
- typo3/sysext/backend/Modules/Wizards/BackendLayoutWizard/index.php+1 −1
- typo3/sysext/backend/Modules/Wizards/ColorpickerWizard/index.php+1 −1
- typo3/sysext/backend/Modules/Wizards/EditWizard/index.php+1 −1
- typo3/sysext/backend/Modules/Wizards/FormsWizard/index.php+1 −1
- typo3/sysext/backend/Modules/Wizards/ListWizard/index.php+1 −1
- typo3/sysext/backend/Modules/Wizards/RteWizard/index.php+1 −1
- typo3/sysext/backend/Modules/Wizards/TableWizard/index.php+1 −1
- typo3/sysext/backend/ext_localconf.php+1 −1
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+1 −1
- typo3/sysext/belog/Classes/Module/BackendLogModuleBootstrap.php+1 −1
- typo3/sysext/beuser/Classes/Hook/SwitchBackUserHook.php+1 −1
- typo3/sysext/cms/layout/db_layout.php+1 −1
- typo3/sysext/cms/layout/db_new_content_el.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+6 −6
- typo3/sysext/core/Classes/Cache/Backend/FileBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/PdoBackend.php+2 −2
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+1 −1
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+1 −1
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+5 −5
- typo3/sysext/core/Classes/Database/DatabaseConnection.php+1 −1
- typo3/sysext/core/Classes/Database/QueryView.php+9 −9
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+10 −10
- typo3/sysext/core/Classes/Database/RelationHandler.php+1 −1
- typo3/sysext/core/Classes/Database/SoftReferenceIndex.php+4 −4
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+18 −18
- typo3/sysext/core/Classes/Encoder/JavaScriptEncoder.php+1 −1
- typo3/sysext/core/Classes/Error/ErrorHandler.php+1 −1
- typo3/sysext/core/Classes/ExtDirect/ExtDirectRouter.php+1 −1
- typo3/sysext/core/Classes/FormProtection/BackendFormProtection.php+1 −1
- typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php+1 −1
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+2 −2
- typo3/sysext/core/Classes/Http/HttpRequest.php+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+1 −1
- typo3/sysext/core/Classes/Integrity/DatabaseIntegrityCheck.php+4 −4
- typo3/sysext/core/Classes/Localization/Parser/AbstractXmlParser.php+1 −1
- typo3/sysext/core/Classes/Localization/Parser/LocallangArrayParser.php+1 −1
- typo3/sysext/core/Classes/Localization/Locales.php+1 −1
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+2 −2
- typo3/sysext/core/Classes/Log/Logger.php+1 −1
- typo3/sysext/core/Classes/Log/LogManager.php+3 −3
- typo3/sysext/core/Classes/Mail/Mailer.php+1 −1
- typo3/sysext/core/Classes/Mail/MailMessage.php+1 −1
- typo3/sysext/core/Classes/Mail/MboxTransport.php+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+4 −4
- typo3/sysext/core/Classes/Resource/Collection/FolderBasedFileCollection.php+1 −1
- typo3/sysext/core/Classes/Resource/Collection/StaticFileCollection.php+1 −1
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/ExtractorRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+2 −2
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+2 −2
- typo3/sysext/core/Classes/Resource/Processing/FileDeletionAspect.php+3 −3
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+1 −1
- typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php+4 −4
- typo3/sysext/core/Classes/Resource/Rendering/RendererRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php+5 −5
- typo3/sysext/core/Classes/Resource/Service/UserFileInlineLabelService.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/UserFileMountService.php+3 −3
- typo3/sysext/core/Classes/Resource/Service/UserStorageCapabilityService.php+2 −2
- typo3/sysext/core/Classes/Resource/Utility/BackendUtility.php+1 −1
- typo3/sysext/core/Classes/Resource/AbstractRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/File.php+2 −2
- typo3/sysext/core/Classes/Resource/FileCollectionRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/FileRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+11 −11
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+6 −6
- typo3/sysext/core/Classes/Resource/StorageRepository.php+4 −4
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+8 −8
- typo3/sysext/core/Classes/Tree/TableConfiguration/TreeDataProviderFactory.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ConfigurationForm.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+3 −3
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+7 −7
- typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+3 −3
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+4 −4
- typo3/sysext/core/Classes/Utility/MonitorUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+4 −4
- typo3/sysext/core/Configuration/TCA/Overrides/be_users.php+1 −1
- typo3/sysext/core/Resources/PHP/FileDumpEID.php+1 −1
- typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/AbstractTestCase.php+2 −2
- typo3/sysext/core/Tests/Unit/Cache/Backend/PdoBackendTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Frontend/PhpFrontendTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Configuration/ConditionMatcherTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Localization/Parser/LocallangXmlParserTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Localization/Parser/XliffParserTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractProcessorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Log/LogManagerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.phpbinary
- typo3/sysext/core/Tests/FunctionalTestCase.php+1 −1
- typo3/sysext/core/Tests/FunctionalTestCaseBootstrapUtility.php+2 −2
- typo3/sysext/core/ext_localconf.php+1 −1
- typo3/sysext/core/ext_tables.php+1 −1
- typo3/sysext/cshmanual/Classes/Controller/HelpModuleController.php+3 −3
- typo3/sysext/cshmanual/mod/index.php+1 −1
- typo3/sysext/dbal/Classes/Controller/ModuleController.php+1 −1
- typo3/sysext/dbal/Classes/Database/DatabaseConnection.php+6 −6
- typo3/sysext/dbal/mod1/index.php+1 −1
- typo3/sysext/documentation/Classes/Domain/Repository/DocumentRepository.php+1 −1
- typo3/sysext/documentation/Classes/Service/DocumentationService.php+1 −1
- typo3/sysext/documentation/ext_localconf.php+1 −1
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+2 −2
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+4 −4
- typo3/sysext/extbase/Classes/Object/Container/ClassInfoCache.php+1 −1
- typo3/sysext/extbase/Classes/Object/Container/ClassInfoFactory.php+1 −1
- typo3/sysext/extbase/Classes/Object/Container/Container.php+5 −5
- typo3/sysext/extbase/Classes/Object/ObjectManager.php+1 −1
- typo3/sysext/extbase/Classes/Object/ObjectManagerException.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryResult.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php+1 −1
- typo3/sysext/extbase/Classes/Scheduler/FieldProvider.php+1 −1
- typo3/sysext/extbase/Classes/Scheduler/Task.php+2 −2
- typo3/sysext/extbase/Classes/Scheduler/TaskExecutor.php+3 −3
- typo3/sysext/extbase/Classes/SignalSlot/Dispatcher.php+1 −1
- typo3/sysext/extbase/Classes/Utility/ExtbaseRequirementsCheckUtility.php+1 −1
- typo3/sysext/extbase/Classes/Utility/FrontendSimulatorUtility.php+1 −1
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php+2 −2
- typo3/sysext/extbase/Scripts/CommandLineLauncher.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/CountTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/InTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/OperatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+1 −1
- typo3/sysext/extbase/ext_localconf.php+1 −1
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php+1 −1
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+1 −1
- typo3/sysext/extensionmanager/Classes/Task/UpdateExtensionListTask.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Importer/ExtensionListUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Importer/MirrorListUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Repository/Helper.php+2 −2
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+1 −1
- typo3/sysext/extensionmanager/ext_localconf.php+1 −1
- typo3/sysext/feedit/Classes/FrontendEditPanel.php+1 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php+6 −6
- typo3/sysext/filelist/Classes/FileList.php+2 −2
- typo3/sysext/filelist/mod1/index.php+1 −1
- typo3/sysext/fluid/Classes/Compatibility/DocbookGeneratorService.php+1 −1
- typo3/sysext/fluid/Classes/Compatibility/TemplateParserBuilder.php+1 −1
- typo3/sysext/fluid/Classes/Core/Compiler/AbstractCompiledTemplate.php+2 −2
- typo3/sysext/fluid/Classes/Core/Parser/SyntaxTree/ViewHelperNode.php+1 −1
- typo3/sysext/fluid/Classes/Core/Parser/Configuration.php+2 −2
- typo3/sysext/fluid/Classes/Core/Widget/Bootstrap.php+3 −3
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php+1 −1
- typo3/sysext/fluid/Classes/View/StandaloneView.php+3 −3
- typo3/sysext/fluid/Classes/View/TemplateView.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/AbstractBackendViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −1
- typo3/sysext/form/Classes/Controller/FormController.php+7 −7
- typo3/sysext/form/Classes/Controller/WizardController.php+4 −4
- typo3/sysext/form/Classes/Domain/Factory/TypoScriptFactory.php+5 −5
- typo3/sysext/form/Classes/Domain/Model/Additional/AbstractAdditionalElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attribute/AbstractAttribute.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Attribute/AttributesAttribute.php+3 −3
- typo3/sysext/form/Classes/Domain/Model/Attribute/NameAttribute.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/AbstractElement.php+5 −5
- typo3/sysext/form/Classes/Domain/Model/Element/ButtonElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/ResetElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Element/SubmitElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Repository/ContentRepository.php+5 −5
- typo3/sysext/form/Classes/PostProcess/MailPostProcessor.php+6 −6
- typo3/sysext/form/Classes/PostProcess/PostProcessor.php+1 −1
- typo3/sysext/form/Classes/PostProcess/RedirectPostProcessor.php+1 −1
- typo3/sysext/form/Classes/Utility/ValidatorUtility.php+1 −1
- typo3/sysext/form/Classes/Validation/AbstractValidator.php+3 −3
- typo3/sysext/form/Classes/Validation/LengthValidator.php+1 −1
- typo3/sysext/form/Classes/View/Confirmation/Element/AbstractElementView.php+1 −1
- typo3/sysext/form/Classes/View/Confirmation/ConfirmationView.php+3 −3
- typo3/sysext/form/Classes/View/Form/Element/AbstractElementView.php+1 −1
- typo3/sysext/form/Classes/View/Mail/Html/Element/AbstractElementView.php+1 −1
- typo3/sysext/form/Classes/View/Mail/Html/HtmlView.php+2 −2
- typo3/sysext/form/Classes/View/Mail/MailView.php+2 −2
- typo3/sysext/form/Classes/View/Wizard/WizardView.php+2 −2
- typo3/sysext/form/Modules/Wizards/FormWizard/index.php+1 −1
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Exception/ProductionExceptionHandler.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+4 −4
- typo3/sysext/frontend/Classes/ContentObject/Menu/GraphicalMenuContentObject.php+8 −8
- typo3/sysext/frontend/Classes/ContentObject/Menu/ImageMenuContentObject.php+4 −4
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+15 −15
- typo3/sysext/frontend/Classes/ContentObject/ContentTableContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+7 −7
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/HierarchicalMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ImageTextContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/SearchResultContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/TemplateContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Controller/DataSubmissionController.php+3 −3
- typo3/sysext/frontend/Classes/Controller/ExtDirectEidController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/PageInformationController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+23 −23
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+7 −7
- typo3/sysext/frontend/Classes/Page/FramesetRenderer.php+1 −1
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+2 −2
- typo3/sysext/frontend/Classes/Page/PageRepository.php+4 −4
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+2 −2
- typo3/sysext/frontend/Classes/Utility/EidUtility.php+2 −2
- typo3/sysext/frontend/Classes/FrontendRequestHandler.php+1 −1
- typo3/sysext/frontend/Resources/PHP/Eid/ExtDirect.php+1 −1
- typo3/sysext/frontend/Resources/PHP/Eid/ShowPic.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+1 −1
- typo3/sysext/frontend/ext_localconf.php+1 −1
- typo3/sysext/func/Classes/Controller/PageFunctionsController.php+1 −1
- typo3/sysext/func/mod1/index.php+1 −1
- typo3/sysext/impexp/app/index.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+9 −9
- typo3/sysext/impexp/Classes/Utility/ImportExportUtility.php+3 −3
- typo3/sysext/impexp/Classes/ImportExport.php+9 −9
- typo3/sysext/impexp/Tests/Functional/Export/AbstractExportTestCase.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Import/AbstractImportTestCase.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/IndexedPagesController.php+7 −7
- typo3/sysext/indexed_search/Classes/Controller/IndexingStatisticsController.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/ModuleController.php+2 −2
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+3 −3
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php+2 −2
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+2 −2
- typo3/sysext/indexed_search/Classes/Example/CrawlerHook.php+3 −3
- typo3/sysext/indexed_search/Classes/Hook/CrawlerFilesHook.php+1 −1
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+5 −5
- typo3/sysext/indexed_search/Classes/Indexer.php+5 −5
- typo3/sysext/indexed_search/Classes/Lexer.php+1 −1
- typo3/sysext/indexed_search/mod/index.php+1 −1
- typo3/sysext/indexed_search/class.crawler.php+1 −1
- typo3/sysext/indexed_search_mysql/Classes/Hook/MysqlFulltextIndexHook.php+2 −2
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+2 −2
- typo3/sysext/info/mod1/index.php+1 −1
- typo3/sysext/info_pagetsconfig/Classes/Controller/InfoPageTyposcriptConfigController.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Step/DatabaseConnect.php+1 −1
- typo3/sysext/install/Classes/Controller/AbstractController.php+2 −2
- typo3/sysext/install/Classes/Report/EnvironmentStatusReport.php+1 −1
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+2 −2
- typo3/sysext/install/Classes/Service/CachingFrameworkDatabaseSchemaService.php+1 −1
- typo3/sysext/install/Classes/Updates/AbstractDatabaseSchemaUpdate.php+1 −1
- typo3/sysext/install/Classes/Updates/AbstractUpdate.php+1 −1
- typo3/sysext/install/Classes/Updates/CompatVersionUpdate.php+1 −1
- typo3/sysext/install/Classes/View/FailsafeView.php+1 −1
- typo3/sysext/install/Classes/View/StandaloneView.php+2 −2
- typo3/sysext/install/Tests/Unit/Controller/Action/Ajax/ExtensionCompatibilityTesterTest.php+1 −1
- typo3/sysext/install/ext_localconf.php+1 −1
- typo3/sysext/lang/Classes/Domain/Repository/LanguageRepository.php+3 −3
- typo3/sysext/lang/Classes/LanguageService.php+4 −4
- typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php+1 −1
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+2 −2
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+3 −3
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+1 −1
- typo3/sysext/lowlevel/Classes/View/ConfigurationView.php+4 −4
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php+6 −6
- typo3/sysext/lowlevel/Classes/CleanerCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/CleanFlexformCommand.php+3 −3
- typo3/sysext/lowlevel/Classes/DeletedRecordsCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/DoubleFilesCommand.php+2 −2
- typo3/sysext/lowlevel/Classes/MissingFilesCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/MissingRelationsCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/OrphanRecordsCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/RteImagesCommand.php+2 −2
- typo3/sysext/lowlevel/Classes/VersionsCommand.php+2 −2
- typo3/sysext/lowlevel/config/index.php+1 −1
- typo3/sysext/lowlevel/dbint/cli/cleaner_cli.php+1 −1
- typo3/sysext/lowlevel/dbint/cli/refindex_cli.php+1 −1
- typo3/sysext/lowlevel/dbint/index.php+1 −1
- typo3/sysext/lowlevel/admin_cli.php+1 −1
- typo3/sysext/openid/Classes/OpenidService.php+1 −1
- typo3/sysext/openid/Classes/Wizard.php+1 −1
- typo3/sysext/openid/class.tx_openid_eid.php+1 −1
- typo3/sysext/openid/class.tx_openid_return.php+1 −1
- typo3/sysext/perm/Classes/Controller/PermissionAjaxController.php+1 −1
- typo3/sysext/perm/Classes/Controller/PermissionModuleController.php+5 −5
- typo3/sysext/perm/mod1/index.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+8 −8
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList.php+5 −5
- typo3/sysext/recordlist/mod1/index.php+1 −1
- typo3/sysext/recordlist/Modules/Wizards/ElementBrowserWizard/index.php+1 −1
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+6 −6
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+1 −1
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+2 −2
- typo3/sysext/recycler/Classes/Domain/Model/Tables.php+1 −1
- typo3/sysext/recycler/mod1/index.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+8 −8
- typo3/sysext/reports/Classes/Report/Status/FalStatus.php+2 −2
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+8 −8
- typo3/sysext/reports/Classes/Report/Status/Status.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/SystemStatus.php+4 −4
- typo3/sysext/reports/Classes/Report/Status/Typo3Status.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/WarningMessagePostProcessor.php+1 −1
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php+3 −3
- typo3/sysext/rsaauth/Classes/Backend/CommandLineBackend.php+1 −1
- typo3/sysext/rsaauth/Classes/Backend/PhpBackend.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/BrowseLinksController.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/ImageRenderingController.php+2 −2
- typo3/sysext/rtehtmlarea/Classes/Controller/ParseHtmlController.php+2 −2
- typo3/sysext/rtehtmlarea/Classes/Controller/SelectImageController.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/SpellCheckingController.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/UserElementsController.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/Abbreviation.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Hook/SoftReferenceHook.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Hook/StatusReportConflictsCheckHook.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php+2 −2
- typo3/sysext/rtehtmlarea/Classes/SelectImage.php+3 −3
- typo3/sysext/rtehtmlarea/Modules/BrowseLinks/index.php+1 −1
- typo3/sysext/rtehtmlarea/Modules/ParseHtml/index.php+1 −1
- typo3/sysext/rtehtmlarea/Modules/SelectImage/index.php+1 −1
- typo3/sysext/rtehtmlarea/Modules/UserElements/index.php+1 −1
- typo3/sysext/rtehtmlarea/Resources/Private/PHP/SpellCheckerEid.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+12 −12
- typo3/sysext/scheduler/Classes/Example/TestTask.php+1 −1
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+5 −5
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionTask.php+1 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionTask.php+1 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingTask.php+1 −1
- typo3/sysext/scheduler/Classes/Execution.php+1 −1
- typo3/sysext/scheduler/Classes/Scheduler.php+2 −2
- typo3/sysext/scheduler/cli/scheduler_cli_dispatch.php+2 −2
- typo3/sysext/scheduler/mod1/index.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+12 −12
- typo3/sysext/setup/mod/index.php+1 −1
- typo3/sysext/sv/Tests/Unit/AuthenticationServiceTest.php+1 −1
- typo3/sysext/sys_action/Classes/ActionTask.php+16 −16
- typo3/sysext/sys_note/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/sys_note/Classes/Hook/InfoModuleHook.php+1 −1
- typo3/sysext/sys_note/Classes/Hook/PageHook.php+1 −1
- typo3/sysext/sys_note/Classes/Hook/RecordListHook.php+1 −1
- typo3/sysext/t3editor/Classes/Hook/FileEditHook.php+2 −2
- typo3/sysext/t3editor/Classes/Hook/TypoScriptTemplateInfoHook.php+4 −4
- typo3/sysext/t3editor/Classes/CodeCompletion.php+2 −2
- typo3/sysext/t3editor/Classes/FormWizard.php+1 −1
- typo3/sysext/t3skin/ext_localconf.php+1 −1
- typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php+5 −5
- typo3/sysext/taskcenter/task/index.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerModuleFunctionController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php+3 −3
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+7 −7
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+10 −10
- typo3/sysext/tstemplate/ts/index.php+1 −1
- typo3/sysext/version/Classes/Controller/VersionModuleController.php+2 −2
- typo3/sysext/version/Classes/DataHandler/CommandMap.php+1 −1
- typo3/sysext/version/Classes/Dependency/DependencyEntityFactory.php+2 −2
- typo3/sysext/version/Classes/Dependency/DependencyResolver.php+1 −1
- typo3/sysext/version/Classes/Dependency/ElementEntityProcessor.php+1 −1
- typo3/sysext/version/Classes/Hook/DataHandlerHook.php+5 −5
- typo3/sysext/version/Classes/Hook/PreviewHook.php+1 −1
- typo3/sysext/version/Classes/Task/AutoPublishTask.php+1 −1
- typo3/sysext/version/Classes/Utility/WorkspacesUtility.php+1 −1
- typo3/sysext/version/cm1/index.php+1 −1
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+1 −1
- typo3/sysext/wizard_crpages/Classes/Controller/CreatePagesWizardModuleFunctionController.php+5 −5
- typo3/sysext/wizard_sortpages/Classes/View/SortPagesWizardModuleFunction.php+3 −3
- typo3/sysext/workspaces/Classes/Controller/AbstractController.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+5 −5
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+5 −5
- typo3/sysext/workspaces/Classes/Domain/Model/CombinedRecord.php+2 −2
- typo3/sysext/workspaces/Classes/Domain/Model/DatabaseRecord.php+2 −2
- typo3/sysext/workspaces/Classes/ExtDirect/AbstractHandler.php+2 −2
- typo3/sysext/workspaces/Classes/ExtDirect/ActionHandler.php+9 −9
- typo3/sysext/workspaces/Classes/ExtDirect/ExtDirectServer.php+5 −5
- typo3/sysext/workspaces/Classes/ExtDirect/MassActionHandler.php+1 −1
- typo3/sysext/workspaces/Classes/ExtDirect/WorkspaceSelectorToolbarItem.php+2 −2
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php+4 −4
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+2 −2
- typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php+1 −1
- typo3/sysext/workspaces/Classes/Service/AdditionalColumnService.php+1 −1
- typo3/sysext/workspaces/Classes/Service/AdditionalResourceService.php+1 −1
- typo3/sysext/workspaces/Classes/Service/AutoPublishService.php+2 −2
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+6 −6
- typo3/sysext/workspaces/Classes/Service/HistoryService.php+2 −2
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+3 −3
- typo3/sysext/workspaces/Classes/Task/AutoPublishTask.php+1 −1
- typo3/ajax.php+1 −1
- typo3/alt_clickmenu.php+1 −1
- typo3/alt_db_navframe.php+1 −1
- typo3/alt_doc.php+1 −1
- typo3/alt_doc_nodoc.php+1 −1
- typo3/alt_file_navframe.php+1 −1
- typo3/backend.php+1 −1
- typo3/browser.php+1 −1
- typo3/db_new.php+1 −1
- typo3/dummy.php+1 −1
- typo3/file_edit.php+1 −1
- typo3/file_newfolder.php+1 −1
- typo3/file_rename.php+1 −1
- typo3/file_upload.php+1 −1
- typo3/index.php+1 −1
- typo3/listframe_loader.php+1 −1
- typo3/login_frameset.php+1 −1
- typo3/logout.php+1 −1
- typo3/mod.php+1 −1
- typo3/move_el.php+1 −1
- typo3/show_rechis.php+1 −1
- typo3/tce_db.php+1 −1
- typo3/tce_file.php+1 −1
- typo3/thumbs.php+1 −1
Review log 37
Show 12 earlier messages
-
Xavier Perseguers uploaded patch set 1 09/22/14, 05:36
-
Stefan Froemken commented on patch set 1 CR -1 09/22/14, 07:26
In my case this is the wrong usage of ::class. ::class returns the full qualified namespace. So why calling ::class with help of the FQN to get the FQN? In my opinion it only makes sense when make use of aliases (use). F.e. use \TYPO3\CMS\Extbase\Persistence\Session; GeneralUtility::makeInstance(Session::class); -
Stefan Neufeind commented on patch set 1 CR +1 09/22/14, 07:40
@Stefan: Yes, it makes "more sense" to do it when it's actually shorter. But having it be a real classname (that an IDE could help shorten, refactor etc.) and not just "some string" would surely be a large plus imho. Please reconsider. -
Thomas Maroschik voted on patch set 1 CR +1 09/22/14, 07:46
-
Stefan Froemken commented on patch set 1 09/22/14, 08:02
OK...I understand this patch, but is there a follow-up planed or already available to make use of the short syntax? -
Stefan Froemken voted on patch set 1 CR 0 09/22/14, 08:27
-
Markus Klein commented on patch set 1 09/22/14, 08:31
Hi! Since this change requires PHP 5.5 for master now, we had a discussion recently and some people voted to have this change rather later than sooner, to not "artificially" introduce hassles at an early stage of version 7. Since I'm working entirely on PHP 5.5, I really don't care when this change will be merged though- ;-) (selfish I know) -
Stefan Neufeind commented on patch set 1 09/22/14, 08:33
Artificially in what way? Do we talk about devs that run a "latest"-checkout of master and can't upgrade to 5.5 / don't have it already? Hmm ... -
Markus Klein commented on patch set 1 09/22/14, 08:37
Did you skip the objectManager->get() calls on purpose? Separate patch? -
Stefan Neufeind commented on patch set 1 CR 0 09/22/14, 08:46
@Markus: Good point, we should add those as well. But since the patchset is huge, imho there is no point re-doing it again and again if the chance is not going to be merged ... -
Xavier Perseguers commented on patch set 1 09/23/14, 05:24
@Markus, this patch is huge, forge ticket shows the script I used and comment says it tackles makeInstance calls. Of course it won't correct every single calls but at least it should be fairly "easy" to review and this should be seen as a larger refactoring umbrella task, so objectmanager->get is imho another patch to create, just as the further refactoring of then trying to use a shorter form, when possible. Mixing everything together will lead to a giant patch nobody is willing and capable of properly reviewing. -
Georg Ringer voted on patch set 1 V +1 CR +1 09/23/14, 08:48
-
Markus Klein commented on patch set 1 09/23/14, 09:36
Of course fine with me. I just wanted to mention them, as I didn't realize that it was targeted to makeInstance only on purpose. Still the question remains when this should be merged. As I wrote earlier there have been discussions about the "early raise of requirements for technical games" -
Xavier Perseguers uploaded patch set 2 09/23/14, 17:23
-
Xavier Perseguers commented on patch set 2 09/23/14, 17:25
@Markus, I get your question, purpose of this patch is not to break because it's fun to break but to introduce as soon as possible the new standard for upcoming clean code. Majority of users is now expected to use LTS so let's move on to clean base for 7.0-dev, take advantage of new requirements and remove legacy ASAP to ensure problems are spotted long before the next release -
Xavier Perseguers commented on patch set 2 09/23/14, 17:27
This new patch has been pushed because we had a merge conflict :) This is the result of exactly the same script as yesterday. -
Markus Klein commented on patch set 2 CR +1 09/23/14, 17:28
It was not my concern! I'm for merging this ASAP too. Helmut and some others asked the question. -
Stefan Neufeind commented on patch set 2 CR +1 09/23/14, 21:45
If the decision go for PHP 5.5 is through, then I'm also in favor of having this at any time (well, now *g*). -
Stefan Neufeind commented on patch set 2 V +1 09/24/14, 00:09
Of course it's not easily possible to test each and every case. But I gave the patch a spin and it worked for me. So the replacement generally works as expected from reading/docs. Since the replacements look good and since they are scripted, I expect those should be fine. -
Xavier Perseguers uploaded patch set 3 09/25/14, 07:23
-
Xavier Perseguers commented on patch set 3 09/25/14, 07:23
New version (again) since merge was not possible anymore -
Stefan Froemken commented on patch set 3 CR +1 V +1 09/25/14, 20:26
I have reviewed nearly 60% of all files. Looks good to me. All tested BE-Modules and FE-Plugins are working. -
Stefan Neufeind commented on patch set 3 CR +1 V +1 09/25/14, 21:36
What I looked at again seems fine to me (further cleanups/optimisations later then). Works fine so far. -
Helmut Hummel commented on patch set 3 CR -1 09/27/14, 08:44
no doubt, I want this change badly. However I would like to propose to postpone it as much as possible/ reasonable to not lock out potential early adopters with lower PHP versions. -
Xavier Perseguers uploaded patch set 4 11/13/14, 11:43
-
Stefan Neufeind commented on patch set 4 CR +1 11/13/14, 11:50
Fine by reading as a first step imho. Haven't double-checked if there are any unreplaced calls - but I don't expect so :-) For cases where we have a "use"-statement already in place, we could (should?) then use shortened names in makeInstance as well. But that can be done in one or more cleanup follow-ups. Syntactically it's for now fine as is. And since the patch is that big, imho we should consider to have it in before it clashes with any other patch again which prevents merging. -
Xavier Perseguers commented on patch set 4 CR -2 11/13/14, 11:52
Please wait, wrongly understood Christian's request, he'd like to have first a patch with a requirement in Install Tool, to have only the ::class thingy here. -
Xavier Perseguers voted on patch set 4 CR 0 11/13/14, 12:54
-
Xavier Perseguers uploaded patch set 5 11/13/14, 12:55
-
Wouter Wolters uploaded patch set 6 11/13/14, 13:03
-
Wouter Wolters voted on patch set 6 V +1 CR +1 11/13/14, 13:22
-
Alexander Opitz voted on patch set 6 V +1 CR +1 11/13/14, 13:30
-
Anja Leichsenring commented on patch set 6 CR +1 V +1 11/13/14, 13:51
tested with unit and functional tests. -
Markus Klein voted on patch set 6 CR +1 11/13/14, 13:56
-
Markus Klein voted on patch set 6 V +1 11/13/14, 14:02
-
Xavier Perseguers commented on patch set 6 CR +2 V +2 11/13/14, 14:03
Thanks for testing! -
Xavier Perseguers merged patch set 6 11/13/14, 14:03