Review main Merged Breaking

32946[!!!][TASK] Remove magic setter for $fromTC

Wouter Wolters CR +2 V +2 Easy +27 −17 updated 09/24/14, 13:40

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +2
    • Tymoteusz Motylewski +1

Issues 1

Files 2

Review log 10

  1. Wouter Wolters uploaded patch set 1 09/23/14, 18:26

  2. Stefan Froemken voted on patch set 1 CR +1 09/23/14, 20:36

  3. Stefan Neufeind voted on patch set 1 CR +1 09/24/14, 01:00

  4. Markus Klein commented on patch set 1 CR +1 V +1 09/24/14, 07:06

    Breaking-61823-RemoveMagicSettterForFromTC.rst:14

    nope, it will only be a warning
  5. Christian Kuhn uploaded patch set 2 09/24/14, 12:17

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 09/24/14, 12:18

  7. Tymoteusz Motylewski voted on patch set 2 CR +1 V +1 09/24/14, 13:25

  8. Wouter Wolters voted on patch set 2 V +2 CR +2 09/24/14, 13:40

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 09/24/14, 13:40

  10. Christian Kuhn merged patch set 2 09/24/14, 13:40