Review main Merged Breaking

32955[!!!][TASK] Remove deprecated file type FILETYPE_SOFTWARE

Wouter Wolters CR +2 V +2 Easy +26 −6 updated 09/26/14, 21:21

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Markus Klein +2
    • Tymoteusz Motylewski +1

Issues 1

Files 2

Review log 5

  1. Wouter Wolters uploaded patch set 1 09/24/14, 18:42

  2. Markus Klein commented on patch set 1 09/24/14, 23:14

    Breaking-81859-FileTypeSoftwareRemoved.rst:14

    not sure about the fatal. I guess it will be converted to the string "FILETYPE_SOFTWARE" and only a notice will be issued.
  3. Tymoteusz Motylewski commented on patch set 1 CR +1 V +1 09/26/14, 19:59

    Breaking-81859-FileTypeSoftwareRemoved.rst:14 Reply

    nop, it fatals at last on PHP 5.5.9 tested with: <?php class ddd { const EXISTING = 'ext'; } echo ddd::EXISTING; echo ddd::NOTEXISTING;
  4. Markus Klein commented on patch set 1 V +2 CR +2 09/26/14, 21:21

    Breaking-81859-FileTypeSoftwareRemoved.rst:14 Reply

    Thanks for testing.
  5. Markus Klein merged patch set 1 09/26/14, 21:21